Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20937

Password change issue when using LDAP

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.6
    • Fix Version/s: 1.9.7
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      As reported by David Binney:

      After upgrading to the new version of moodle 1.9.6 i have been asked to change the admin password based on the password policy default. This would normally be ok if there was one admin and that was not linked to LDAP. However, our accounts are linked to ldap so it is impossible for moodle to manage the passwords in this way. So i was wondering if there is a way that the default can be permenantly set back to false/disabled or an alternative that will not require any changes of passwords from moodle's part?

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            ppollet Patrick Pollet added a comment -

            Hello,

            This has been fixed yesterday by Petr, where I reported the very same issue with CAS and Shiboleth authentifications . See MDL-20933.
            However I do not know when the patches will hit CVS ...

            In the meantime, what I have done to be able to login as admin is to comment out these lines in lib/moodlelib.php

            // print_error('nopasswordchangeforced', 'auth'); <--------- this line appears at line # 1963 and 3309

            Cheers

            Show
            ppollet Patrick Pollet added a comment - Hello, This has been fixed yesterday by Petr, where I reported the very same issue with CAS and Shiboleth authentifications . See MDL-20933. However I do not know when the patches will hit CVS ... In the meantime, what I have done to be able to login as admin is to comment out these lines in lib/moodlelib.php // print_error('nopasswordchangeforced', 'auth'); <--------- this line appears at line # 1963 and 3309 Cheers
            Hide
            skodak Petr Skoda added a comment -

            yes, patches were in cvs yesterday already, it will be in next weekly build, we decided to change the upgrade a bit more, going to commit the final version later today

            Show
            skodak Petr Skoda added a comment - yes, patches were in cvs yesterday already, it will be in next weekly build, we decided to change the upgrade a bit more, going to commit the final version later today
            Hide
            skodak Petr Skoda added a comment -

            oh, forget to emphasise - you need to launch the site upgrade before login by going to admin/index.php manually

            Show
            skodak Petr Skoda added a comment - oh, forget to emphasise - you need to launch the site upgrade before login by going to admin/index.php manually
            Hide
            skodak Petr Skoda added a comment -

            reassigning back to sam, could you please review my changes and test 1.8.x, thanks a lot

            Show
            skodak Petr Skoda added a comment - reassigning back to sam, could you please review my changes and test 1.8.x, thanks a lot
            Hide
            skodak Petr Skoda added a comment -

            please close this when finished

            Show
            skodak Petr Skoda added a comment - please close this when finished
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Petr, everything looks good an runs smoothly.
            Testing on complete upgrade, and sites that were upgraded by the initial upgrade routine, everything ran perfectly.
            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Petr, everything looks good an runs smoothly. Testing on complete upgrade, and sites that were upgraded by the initial upgrade routine, everything ran perfectly. Cheers Sam
            Hide
            donkeyx David Binney added a comment -

            Hey Sam,

            What cvs build are you expecting this to be integrated into because we are currently on build ($version = 2007101562) and I would like to upgrade this as soon as possible. I would prefer not to hack this into svn then have to revert it next week or whenever this happens? But if it will be a little away, then i might make the change and will just have to keep notes on when this is patched to revert my change.

            PS: I am David Binney

            Show
            donkeyx David Binney added a comment - Hey Sam, What cvs build are you expecting this to be integrated into because we are currently on build ($version = 2007101562) and I would like to upgrade this as soon as possible. I would prefer not to hack this into svn then have to revert it next week or whenever this happens? But if it will be a little away, then i might make the change and will just have to keep notes on when this is patched to revert my change. PS: I am David Binney
            Hide
            skodak Petr Skoda added a comment -

            it is already in cvs, it will be also in the next weekly which might actually be 1.9.7, it is likely that the weekly will be tagged tomorrow

            Show
            skodak Petr Skoda added a comment - it is already in cvs, it will be also in the next weekly which might actually be 1.9.7, it is likely that the weekly will be tagged tomorrow
            Hide
            andyjdavis Andrew Davis added a comment -

            The fix looks logical enough. Closing.

            Show
            andyjdavis Andrew Davis added a comment - The fix looks logical enough. Closing.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Nov/09