Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20938

Wrong Colspan in Gradebook in Edit-Mode

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.6
    • Fix Version/s: 1.9.7
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      If you activate edit mode in the grade book, the "Controls"-Field has a wrong colpsan (colspan='1' if no idnumber is shown, colspan='2' otherwise), see screenshots 2)(with cell boundaries highlighted).

      /cvsroot/moodle/moodle/grade/report/grader/lib.php
      lines 1300 following:
      $colspan = '';
      if ($showuseridnumber)

      { $colspan = 'colspan="2"'; }

      if (!$fixedstudents)

      { $iconshtml .= '<th class="header c0 controls" scope="row" '.$colspan.'>'.$this->get_lang_string('controls','grades').'</th>'; }

      should be:
      $colspan = 'colspan="2"';
      if ($showuseridnumber) { $colspan = 'colspan="3"'; }

      if (!$fixedstudents) { $iconshtml .= '<th class="header c0 controls" scope="row" '.$colspan.'>'.$this->get_lang_string('controls','grades').'</th>'; }

      I assume, a column was introduced and the code is old code.
      Similar lines (similar error??) are at lines 1173 and 1263.
      Screenshot 3) shows the right cell boundaries.

        Attachments

        1. 2_Grades- View_boundaries.png
          2_Grades- View_boundaries.png
          6 kB
        2. 3_Grades- View_boundaries_ok.png
          3_Grades- View_boundaries_ok.png
          4 kB
        3. garder_avgs_ko.png
          garder_avgs_ko.png
          10 kB
        4. garder_avgs_ok.png
          garder_avgs_ok.png
          18 kB
        5. lib.php.patch
          0.7 kB

          Issue Links

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              schuhmann Martin Schuhmann
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Nov/09