Moodle
  1. Moodle
  2. MDL-20961

No user warning displayed to teacher on backup

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.6
    • Fix Version/s: 1.9.8
    • Component/s: Backup
    • Labels:
      None
    • Environment:
      Any 1.9.6+ with recent security enhancements
    • Database:
      Any
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Teacher without backup user data capability sees warnings and info about no users in backup ay this page /backup/backup.php

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Eloy Lafuente (stronk7) added a comment -

            Hi Ray,

            do you mean this message:

            qt. Notice: You have selected to backup no users ("none"), so all the modules backup have been switched to "without user data" mode. Please note that the "exercise" and "workshop" modules aren't compatible with this type of backup, so they have been deactivated completely.

            That is expected behaviour since ages ago each time one backup without users is created. It's one warning telling the user that such backup is incomplete (from a restore completely point of view).

            Or are you talking about other type of warnings (PHP?). I don't get any here. Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Hi Ray, do you mean this message: qt. Notice: You have selected to backup no users ("none"), so all the modules backup have been switched to "without user data" mode. Please note that the "exercise" and "workshop" modules aren't compatible with this type of backup, so they have been deactivated completely. That is expected behaviour since ages ago each time one backup without users is created. It's one warning telling the user that such backup is incomplete (from a restore completely point of view). Or are you talking about other type of warnings (PHP?). I don't get any here. Ciao
            Hide
            Ray Lawrence added a comment -

            Hi Eloy,

            Yes, that's the one and I'm familiar with it. However, it's redundant now as a teacher without the userinfo backup capapbility (the default) can't include users or user data. For the new generation of moodle teachers who won't have this capability this message is confusing as is the infomation below that there is no user data included.

            Show
            Ray Lawrence added a comment - Hi Eloy, Yes, that's the one and I'm familiar with it. However, it's redundant now as a teacher without the userinfo backup capapbility (the default) can't include users or user data. For the new generation of moodle teachers who won't have this capability this message is confusing as is the infomation below that there is no user data included.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Hi Ray, I see your point... completely... but I'd keep that message there for some time (until 2.0 / 6 months, the first to arrive) to allow people (teachers) to know that their current backups aren't, any more, "complete" (usable to restore a course totally).

            I'm 99% sure that 99% of teachers won't notice any difference unless they begin seeing that annoying red message. Else they will continue relying on those backups to store and reset their courses without knowing that it isn't anymore the correct way to keep the old ones completely saved.

            Just IMO

            Show
            Eloy Lafuente (stronk7) added a comment - Hi Ray, I see your point... completely... but I'd keep that message there for some time (until 2.0 / 6 months, the first to arrive) to allow people (teachers) to know that their current backups aren't, any more, "complete" (usable to restore a course totally). I'm 99% sure that 99% of teachers won't notice any difference unless they begin seeing that annoying red message. Else they will continue relying on those backups to store and reset their courses without knowing that it isn't anymore the correct way to keep the old ones completely saved. Just IMO
            Hide
            Ray Lawrence added a comment -

            Hi,

            I can see the logic in that but the message doesn't help as it highlights options that are not available to teachers by default any more:

            "Notice: You have selected to backup no users ("none"), so all the modules backup have been switched to "without user data" mode. Please note that the "exercise" and "workshop" modules aren't compatible with this type of backup, so they have been deactivated completely."

            I suggest it's revised to meet your objective and to make it more appropriate to the new status of backups:

            "This backup does not contain information from user profiles or user data from activities e.g. quiz attempts, forum posts, wiki pages, glossary entries, chat sessions etc. Please note that the "Exercise" and "Workshop" modules aren't compatible with this type of backup and are not included."

            Please check the statement about exercise and workshop are correct.

            Ray

            Added Helen as watcher.

            Show
            Ray Lawrence added a comment - Hi, I can see the logic in that but the message doesn't help as it highlights options that are not available to teachers by default any more: "Notice: You have selected to backup no users ("none"), so all the modules backup have been switched to "without user data" mode. Please note that the "exercise" and "workshop" modules aren't compatible with this type of backup, so they have been deactivated completely." I suggest it's revised to meet your objective and to make it more appropriate to the new status of backups: "This backup does not contain information from user profiles or user data from activities e.g. quiz attempts, forum posts, wiki pages, glossary entries, chat sessions etc. Please note that the "Exercise" and "Workshop" modules aren't compatible with this type of backup and are not included." Please check the statement about exercise and workshop are correct. Ray Added Helen as watcher.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Hi Helen,

            do you think it's ok to introduce the 2nd string for users missing the moodle:backup:userinfo capability? If so I can easily:

            • keep the original string for old uses
            • create the new one and apply it only to ppl missing the capability (backupmissinguserinfoperms as string name).

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Hi Helen, do you think it's ok to introduce the 2nd string for users missing the moodle:backup:userinfo capability? If so I can easily: keep the original string for old uses create the new one and apply it only to ppl missing the capability (backupmissinguserinfoperms as string name). Ciao
            Hide
            Helen Foster added a comment -

            Hi Ray and Eloy,

            I'm in agreement with Ray about having a new message. How about (based on Ray's suggestion, just shortened a little):

            Note: This backup contains no user data. Exercise and Workshop activities will not be included in the backup, since these modules are not compatible with this type of backup.

            Ray, thanks a lot for reporting this issue (and many similar ones). Your attention to detail is much appreciated.

            Show
            Helen Foster added a comment - Hi Ray and Eloy, I'm in agreement with Ray about having a new message. How about (based on Ray's suggestion, just shortened a little): Note: This backup contains no user data. Exercise and Workshop activities will not be included in the backup, since these modules are not compatible with this type of backup. Ray, thanks a lot for reporting this issue (and many similar ones). Your attention to detail is much appreciated.
            Hide
            Helen Foster added a comment -

            Eloy, how about rewording the existing string to:

            Note: This backup contains no users and so all activities have been switched to "without user data" mode. Exercise and Workshop activities will not be included in the backup, since these modules are not compatible with this type of backup.

            Show
            Helen Foster added a comment - Eloy, how about rewording the existing string to: Note: This backup contains no users and so all activities have been switched to "without user data" mode. Exercise and Workshop activities will not be included in the backup, since these modules are not compatible with this type of backup.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Done. Added new string for users lacking the capability and kept old one (nicely reworded by Helen) to users having the capability.

            Resolving as fixed. Thanks Ray and Helen! Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Done. Added new string for users lacking the capability and kept old one (nicely reworded by Helen) to users having the capability. Resolving as fixed. Thanks Ray and Helen! Ciao
            Hide
            Ray Lawrence added a comment -

            Excellent! Thanks.

            Show
            Ray Lawrence added a comment - Excellent! Thanks.
            Hide
            Helen Foster added a comment -

            Closing, as messages for admin and teacher are displayed correctly (and have been for ages!)

            Ray, thanks again for your input and Eloy, thanks for fixing

            Show
            Helen Foster added a comment - Closing, as messages for admin and teacher are displayed correctly (and have been for ages!) Ray, thanks again for your input and Eloy, thanks for fixing

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: