Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20989

modedit.php throws notices if a module has FEATURE_MOD_INTRO set to false

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      If a module has FEATURE_MOD_INTRO set to false then when creating a new instance of the module you will get notices displayed about a missing property.
      Solution is modedit.php simply needs to be made to check the features of a module to ensure it does have an intro field.

        Gliffy Diagrams

          Activity

          samhemelryk Sam Hemelryk created issue -
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi Petr, I have attached a simple patch to this bug could you please have a look at it for me. It fixes the issue but is there more areas where this should also be checked in the new intro related code?

          Show
          samhemelryk Sam Hemelryk added a comment - Hi Petr, I have attached a simple patch to this bug could you please have a look at it for me. It fixes the issue but is there more areas where this should also be checked in the new intro related code?
          samhemelryk Sam Hemelryk made changes -
          Field Original Value New Value
          Attachment modedit.php.20091127.patch [ 18999 ]
          Hide
          skodak Petr Skoda added a comment -

          nope, we have plugin_supports($type, $name, $feature, $default=null) for this

          Show
          skodak Petr Skoda added a comment - nope, we have plugin_supports($type, $name, $feature, $default=null) for this
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Awesome, thanks for the feedback Petr, have commit a fix that uses plugin_supports

          Show
          samhemelryk Sam Hemelryk added a comment - Awesome, thanks for the feedback Petr, have commit a fix that uses plugin_supports
          samhemelryk Sam Hemelryk made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          dougiamas Martin Dougiamas made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          QA Assignee nobody
          dougiamas Martin Dougiamas made changes -
          Workflow jira [ 34309 ] MDL Workflow [ 63488 ]
          dougiamas Martin Dougiamas made changes -
          Workflow MDL Workflow [ 63488 ] MDL Full Workflow [ 92730 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10