Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.8
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      login/mnet_email.php has several hardcoded langs:
      MNET ID Provider

      notice("You should be able to login at your <a href=\"{$host->wwwroot}/login/\">{$host->name}</a> provider.");

      Find Login

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            andyjdavis Andrew Davis added a comment -

            Patches attached for review. Am I putting the strings in the right place? The page mnet_email.php is under /login but it is mnet related.

            Show
            andyjdavis Andrew Davis added a comment - Patches attached for review. Am I putting the strings in the right place? The page mnet_email.php is under /login but it is mnet related.
            Hide
            danmarsden Dan Marsden added a comment -

            makes sense to me!

            I might have stored get_string('mnetidprovider','mnet') in a string as it's used a few times, but it's cached so probably doesn't make any difference.

            Show
            danmarsden Dan Marsden added a comment - makes sense to me! I might have stored get_string('mnetidprovider','mnet') in a string as it's used a few times, but it's cached so probably doesn't make any difference.
            Hide
            andyjdavis Andrew Davis added a comment -

            Should probably store it in a local variable regardless.

            Show
            andyjdavis Andrew Davis added a comment - Should probably store it in a local variable regardless.
            Hide
            andyjdavis Andrew Davis added a comment -

            updated patch.

            Show
            andyjdavis Andrew Davis added a comment - updated patch.
            Hide
            skodak Petr Skoda added a comment -

            +1 for commit

            Show
            skodak Petr Skoda added a comment - +1 for commit
            Hide
            andyjdavis Andrew Davis added a comment -

            committed.

            Show
            andyjdavis Andrew Davis added a comment - committed.
            Hide
            danmarsden Dan Marsden added a comment -

            looks fine to me! - thanks Andrew!

            Show
            danmarsden Dan Marsden added a comment - looks fine to me! - thanks Andrew!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Mar/10