Details
Bug
Minor
Description
login/mnet_email.php has several hardcoded langs:
MNET ID Provider
notice("You should be able to login at your <a href=\"{$host->wwwroot}/login/\">{$host->name}</a> provider.");
Find Login
Gliffy Diagrams
Activity
makes sense to me!
I might have stored get_string('mnetidprovider','mnet') in a string as it's used a few times, but it's cached so probably doesn't make any difference.
Show
Dan Marsden
added a comment - makes sense to me!
I might have stored get_string('mnetidprovider','mnet') in a string as it's used a few times, but it's cached so probably doesn't make any difference.
Should probably store it in a local variable regardless.
Show
Andrew Davis
added a comment - Should probably store it in a local variable regardless.
updated patch.
Show
Andrew Davis
added a comment - updated patch.
+1 for commit
Show
Petr Skoda
added a comment - +1 for commit
committed.
Show
Andrew Davis
added a comment - committed.
looks fine to me! - thanks Andrew!
Show
Dan Marsden
added a comment - looks fine to me! - thanks Andrew!
Patches attached for review. Am I putting the strings in the right place? The page mnet_email.php is under /login but it is mnet related.