Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21029

global glossary auto linking to glossary on start page is broken after last update

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.8
    • Component/s: Glossary
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      After the last changes in showentry.php all glossaries not within the actual course are ignored. No autolinking to global glossaries on the start page works any more.

      The patch below is a workaround to integrate the modules on the start page into the check. For this solution the global glossary must be on the start page - global glossaries in other courses are not working.

      Patch
      Index: showentry.php
      ===================================================================
      RCS file: /cvsroot/moodle/moodle/mod/glossary/showentry.php,v
      retrieving revision 1.40.2.1
      diff -u -r1.40.2.1 showentry.php
      — showentry.php 22 Nov 2009 10:34:56 -0000 1.40.2.1
      +++ showentry.php 3 Dec 2009 09:21:29 -0000
      @@ -43,9 +43,12 @@

      if ($entries) {
      $modinfo = get_fast_modinfo($course);
      + if ($site = get_record("course", "id", 1))

      { + $sitemodinfo = get_fast_modinfo($site); + }

      foreach ($entries as $key => $entry) {
      // make sure the entry is visible

      • if (empty($modinfo->cms[$entry->cmid]->uservisible)) {
        + if (empty($modinfo->cms[$entry->cmid]>uservisible) && empty($sitemodinfo>cms[$entry->cmid]->uservisible)) { unset($entries[$key]); continue; }

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Mar/10