Moodle
  1. Moodle
  2. MDL-21097

Non-editing teacher role cannot view/hide activities with permission set to allow.

    Details

    • Testing Instructions:
      Hide

      The modification relates to items in course settings:

      • Turn editing on/off
      • Activity chooser on/off (visible only in editing mode, not available on frontpage)
      • Edit course
      1. Create a course, add several modules in it
      2. Enrol one user with teacher role and one user with non-editing teacher role
      3. Also give two users those roles on frontpage
      4. Having default capabilities for roles, make sure that teacher can see all nodes listed above and non-editing teacher can see none (for both course and frontpage)
      5. Withdraw from teacher capability to edit course, give non-editing teacher capability course:activityvisibility
      6. Make sure teacher can not see node 'edit course' but can turn editing on and when editing is on he can manage activities (again, course and frontpage)
      7. Make sure non-editing teacher can turn editing on, does not see both other items and can show/hide modules
      8. Create a role with only course:update capability and no other course capabilities (awkward but still). Make sure user is able to switch editing mode on and edit sections (Note: In 2.3 there is no capability 'course:movesections' and in order to move sections capability 'course:update' is checked.)

      Will be really good if also can be tested when non-editing teacher has only capability to hide sections (revoke back activityvisibility) or capability to move sections.

      In 2.5+ (change not backported) non-editing teacher with only capability to set the current section should be able to do it but only in topics format.

      Sorry, all versions need to be tested separately (except 2.5/master is still on-sync).

      Show
      The modification relates to items in course settings: Turn editing on/off Activity chooser on/off (visible only in editing mode, not available on frontpage) Edit course Create a course, add several modules in it Enrol one user with teacher role and one user with non-editing teacher role Also give two users those roles on frontpage Having default capabilities for roles, make sure that teacher can see all nodes listed above and non-editing teacher can see none (for both course and frontpage) Withdraw from teacher capability to edit course, give non-editing teacher capability course:activityvisibility Make sure teacher can not see node 'edit course' but can turn editing on and when editing is on he can manage activities (again, course and frontpage) Make sure non-editing teacher can turn editing on, does not see both other items and can show/hide modules Create a role with only course:update capability and no other course capabilities (awkward but still). Make sure user is able to switch editing mode on and edit sections (Note: In 2.3 there is no capability 'course:movesections' and in order to move sections capability 'course:update' is checked.) Will be really good if also can be tested when non-editing teacher has only capability to hide sections (revoke back activityvisibility) or capability to move sections. In 2.5+ (change not backported) non-editing teacher with only capability to set the current section should be able to do it but only in topics format. Sorry, all versions need to be tested separately (except 2.5/master is still on-sync).
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull 2.4 Branch:
      wip-MDL-21097-m24
    • Pull 2.5 Branch:
      wip-MDL-21097-m25
    • Pull Master Branch:
      wip-MDL-21097-master
    • Rank:
      5719

      Description

      With the activity view/hide capability (Capabilities/moodle/course:activityvisibility) set to allow in the non-editing teacher role, the non-editing teacher still cannot do make activites visible or hidden. The only to allow them to do this is to give the manage activities capability.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d;

          lqjjLKA0p6

          Show
          Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
          Hide
          Stefan Nychka added a comment -

          Hi.

          Not sure who needs to comment, but this is still an issue in 2.1.3 ... if set, I see no way for a role w/o manage activities to hide/unhide a resource/activity.

          There's no Turn editing on button, no eye icon (and no way to edit the settings and change visibility ... although this for obvious reasons won't solve the issue ... e.g., for a Label)

          Show
          Stefan Nychka added a comment - Hi. Not sure who needs to comment, but this is still an issue in 2.1.3 ... if set, I see no way for a role w/o manage activities to hide/unhide a resource/activity. There's no Turn editing on button, no eye icon (and no way to edit the settings and change visibility ... although this for obvious reasons won't solve the issue ... e.g., for a Label)
          Hide
          Eliz Tchakarian added a comment -

          Hello,
          This is definitely still an issue in 2.3 as well. Once manage activities is allowed, the non-editing teacher can do anything with them. However, I would like that to be limited to just hide/show activities. I don't want the non-editing teacher to be able to delete an activity. Is there a solution in the works?
          Thank you.

          Show
          Eliz Tchakarian added a comment - Hello, This is definitely still an issue in 2.3 as well. Once manage activities is allowed, the non-editing teacher can do anything with them. However, I would like that to be limited to just hide/show activities. I don't want the non-editing teacher to be able to delete an activity. Is there a solution in the works? Thank you.
          Hide
          Mark McCall added a comment -

          This is starting to become a more common request for Moodle Sites that have pre-built courses from publishers that do not want to give full edit access to clients that are using their content; but, need the non-editing teacher to have the ability to open up activities at different times within the course. There is not another work around that I have been able to find.

          Show
          Mark McCall added a comment - This is starting to become a more common request for Moodle Sites that have pre-built courses from publishers that do not want to give full edit access to clients that are using their content; but, need the non-editing teacher to have the ability to open up activities at different times within the course. There is not another work around that I have been able to find.
          Hide
          Marina Glancy added a comment -

          Hi all. Just saw this bug. The fix is tiny - see submitted branch. But not sure if it can be backported, too many things potentially get affected.

          Show
          Marina Glancy added a comment - Hi all. Just saw this bug. The fix is tiny - see submitted branch. But not sure if it can be backported, too many things potentially get affected.
          Hide
          Marina Glancy added a comment -

          by the way, there is another issue: I removed from teacher the capability to update the course (moodle/course:update) and for him the link to switch on/off the editing mode disappeared. Even though he manage the modules, he can't switch to editing mode in this course and update them.

          Show
          Marina Glancy added a comment - by the way, there is another issue: I removed from teacher the capability to update the course (moodle/course:update) and for him the link to switch on/off the editing mode disappeared. Even though he manage the modules, he can't switch to editing mode in this course and update them.
          Hide
          Dan Poltawski added a comment -

          Feel free to take it then Marina

          Show
          Dan Poltawski added a comment - Feel free to take it then Marina
          Hide
          Marina Glancy added a comment -

          master/2.5 branch is blocked by MDL-39801

          Show
          Marina Glancy added a comment - master/2.5 branch is blocked by MDL-39801
          Hide
          Marina Glancy added a comment -

          Suddenly it became not-so-small issues because of:

          A) The same applies to frontpage
          B) The same applies to other limited-managing capabilities such as:
          moodle/course:sectionvisibility
          moodle/course:movesections
          moodle/course:setcurrentsection
          C) Apparently editing teacher with revoked course:update capability suddenly is unable to turn editing mode on and manage activities

          Also in 2.5 some code from navigationlib was moved to course renderer, so the fix is different.

          Note TO INTEGRATORS: since moodle/course:setcurrentsection is applicable only to topics format, I preferred to keep it inside format and not change /course/view.php. This is submitted as a separate commit for 2.5 and master only.

          Show
          Marina Glancy added a comment - Suddenly it became not-so-small issues because of: A) The same applies to frontpage B) The same applies to other limited-managing capabilities such as: moodle/course:sectionvisibility moodle/course:movesections moodle/course:setcurrentsection C) Apparently editing teacher with revoked course:update capability suddenly is unable to turn editing mode on and manage activities Also in 2.5 some code from navigationlib was moved to course renderer, so the fix is different. Note TO INTEGRATORS: since moodle/course:setcurrentsection is applicable only to topics format, I preferred to keep it inside format and not change /course/view.php. This is submitted as a separate commit for 2.5 and master only.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23, 24, 25 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23, 24, 25 & master), thanks!
          Hide
          Frédéric Massart added a comment - - edited

          I am going to have a meeting, so posting what I discovered so far (I have tested 2.3 and 2.4):

          2.3, non-editing teacher, in a main course page.

          Capability "moodle/course:movesections" was not found! This has to be fixed in code.
          line 377 of /lib/accesslib.php: call to debugging()
          line 503 of /lib/accesslib.php: call to has_capability()
          line 811 of /lib/pagelib.php: call to has_any_capability()
          line 142 of /course/view.php: call to moodle_page->user_allowed_editing()
          Capability "moodle/course:movesections" was not found! This has to be fixed in code.
          line 377 of /lib/accesslib.php: call to debugging()
          line 503 of /lib/accesslib.php: call to has_capability()
          line 811 of /lib/pagelib.php: call to has_any_capability()
          line 230 of /course/view.php: call to moodle_page->user_allowed_editing()
          Capability "moodle/course:movesections" was not found! This has to be fixed in code.
          line 377 of /lib/accesslib.php: call to debugging()
          line 503 of /lib/accesslib.php: call to has_capability()
          line 811 of /lib/pagelib.php: call to has_any_capability()
          line 3586 of /lib/navigationlib.php: call to moodle_page->user_allowed_editing()
          line 3310 of /lib/navigationlib.php: call to settings_navigation->load_course_settings()
          line 716 of /lib/pagelib.php: call to settings_navigation->initialise()
          line 732 of /lib/pagelib.php: call to moodle_page->magic_get_settingsnav()
          line 133 of /blocks/settings/block_settings.php: call to moodle_page->__get()
          line 281 of /blocks/moodleblock.class.php: call to block_settings->get_content()
          line 232 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()
          line 937 of /lib/blocklib.php: call to block_base->get_content_for_output()
          line 989 of /lib/blocklib.php: call to block_manager->create_block_contents()
          line 352 of /lib/blocklib.php: call to block_manager->ensure_content_created()
          line 6 of /theme/base/layout/general.php: call to block_manager->region_has_content()
          line 771 of /lib/outputrenderers.php: call to include()
          line 718 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
          line ? of unknownfile: call to core_renderer->header()
          line 1484 of /lib/setuplib.php: call to call_user_func_array()
          line 237 of /course/view.php: call to bootstrap_renderer->__call()
          

          2.3, non-editing teacher, with only capability to control section visibility:
          2.4, non-editing teacher, with only capability to control section visibility:

          • Once hidden, the section cannot be unhidden. (refresh after hiding)

          2.3, only with course update
          2.4, only with course update

          • Cannot switch editing mode (so cannot edit section either)
          • Part of the course settings cannot be edited

          2.3, non-editing teacher, on front page
          2.4, non-editing teacher, on front page

          • Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible.

          2.4, non-editing teacher, on course page, with capability to move sections

          • The section is moved, but the JS fails and so the loading spinner does not disappear:
          Uncaught TypeError: Cannot call method 'swap' of null format.js:44
          M.course.format.swap_sections format.js:44
          Y.io.on.success yui_combo.php:204
          Y.Subscriber._notify simpleyui.js:10407
          Y.Subscriber.notify simpleyui.js:10436
          Y.CustomEvent._notify simpleyui.js:10122
          Y.CustomEvent._procSubs simpleyui.js:10228
          Y.CustomEvent.fireSimple simpleyui.js:10196
          Y.CustomEvent.fire simpleyui.js:10178
          ET.fire simpleyui.js:11234
          IO._evt simpleyui.js:17510
          IO.success simpleyui.js:17580
          IO._result simpleyui.js:17768
          (anonymous function) simpleyui.js:17793
          
          Show
          Frédéric Massart added a comment - - edited I am going to have a meeting, so posting what I discovered so far (I have tested 2.3 and 2.4): 2.3, non-editing teacher, in a main course page. Capability "moodle/course:movesections" was not found! This has to be fixed in code. line 377 of /lib/accesslib.php: call to debugging() line 503 of /lib/accesslib.php: call to has_capability() line 811 of /lib/pagelib.php: call to has_any_capability() line 142 of /course/view.php: call to moodle_page->user_allowed_editing() Capability "moodle/course:movesections" was not found! This has to be fixed in code. line 377 of /lib/accesslib.php: call to debugging() line 503 of /lib/accesslib.php: call to has_capability() line 811 of /lib/pagelib.php: call to has_any_capability() line 230 of /course/view.php: call to moodle_page->user_allowed_editing() Capability "moodle/course:movesections" was not found! This has to be fixed in code. line 377 of /lib/accesslib.php: call to debugging() line 503 of /lib/accesslib.php: call to has_capability() line 811 of /lib/pagelib.php: call to has_any_capability() line 3586 of /lib/navigationlib.php: call to moodle_page->user_allowed_editing() line 3310 of /lib/navigationlib.php: call to settings_navigation->load_course_settings() line 716 of /lib/pagelib.php: call to settings_navigation->initialise() line 732 of /lib/pagelib.php: call to moodle_page->magic_get_settingsnav() line 133 of /blocks/settings/block_settings.php: call to moodle_page->__get() line 281 of /blocks/moodleblock.class.php: call to block_settings->get_content() line 232 of /blocks/moodleblock.class.php: call to block_base->formatted_contents() line 937 of /lib/blocklib.php: call to block_base->get_content_for_output() line 989 of /lib/blocklib.php: call to block_manager->create_block_contents() line 352 of /lib/blocklib.php: call to block_manager->ensure_content_created() line 6 of /theme/base/layout/general.php: call to block_manager->region_has_content() line 771 of /lib/outputrenderers.php: call to include() line 718 of /lib/outputrenderers.php: call to core_renderer->render_page_layout() line ? of unknownfile: call to core_renderer->header() line 1484 of /lib/setuplib.php: call to call_user_func_array() line 237 of /course/view.php: call to bootstrap_renderer->__call() 2.3, non-editing teacher, with only capability to control section visibility: 2.4, non-editing teacher, with only capability to control section visibility: Once hidden, the section cannot be unhidden. (refresh after hiding) 2.3, only with course update 2.4, only with course update Cannot switch editing mode (so cannot edit section either) Part of the course settings cannot be edited 2.3, non-editing teacher, on front page 2.4, non-editing teacher, on front page Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible. 2.4, non-editing teacher, on course page, with capability to move sections The section is moved, but the JS fails and so the loading spinner does not disappear: Uncaught TypeError: Cannot call method 'swap' of null format.js:44 M.course.format.swap_sections format.js:44 Y.io.on.success yui_combo.php:204 Y.Subscriber._notify simpleyui.js:10407 Y.Subscriber.notify simpleyui.js:10436 Y.CustomEvent._notify simpleyui.js:10122 Y.CustomEvent._procSubs simpleyui.js:10228 Y.CustomEvent.fireSimple simpleyui.js:10196 Y.CustomEvent.fire simpleyui.js:10178 ET.fire simpleyui.js:11234 IO._evt simpleyui.js:17510 IO.success simpleyui.js:17580 IO._result simpleyui.js:17768 (anonymous function) simpleyui.js:17793
          Hide
          Marina Glancy added a comment -

          don't you love moodle capabilities?
          (btw I'm preparing the patch)

          Show
          Marina Glancy added a comment - don't you love moodle capabilities? (btw I'm preparing the patch)
          Hide
          Marina Glancy added a comment -

          2.3, 2.4, non-editing teacher, with only capability to control section visibility:
          Once hidden, the section cannot be unhidden. (refresh after hiding)

          probably not going to address this now - it's quite unreal situation when user can change section visibility but is not able to see hidden sections. Besides from cap point of view user is able to do it it's just that control is not shown.

          2.3, 2.4, non-editing teacher, on front page
          Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible.

          not related to this issue, please create a separate bug for it

          2.3, 2.4, only with course update
          Part of the course settings cannot be edited

          also not related, half of fields have separate capabilities

          2.4, non-editing teacher, on course page, with capability to move sections
          The section is moved, but the JS fails and so the loading spinner does not disappear:

          not related. Same happens to editing teacher on MOODLE_24_STABLE when he is trying to move section before general section. Probably another issue (de-ja-vue for me)

          Show
          Marina Glancy added a comment - 2.3, 2.4, non-editing teacher, with only capability to control section visibility: Once hidden, the section cannot be unhidden. (refresh after hiding) probably not going to address this now - it's quite unreal situation when user can change section visibility but is not able to see hidden sections. Besides from cap point of view user is able to do it it's just that control is not shown. 2.3, 2.4, non-editing teacher, on front page Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible. not related to this issue, please create a separate bug for it 2.3, 2.4, only with course update Part of the course settings cannot be edited also not related, half of fields have separate capabilities 2.4, non-editing teacher, on course page, with capability to move sections The section is moved, but the JS fails and so the loading spinner does not disappear: not related. Same happens to editing teacher on MOODLE_24_STABLE when he is trying to move section before general section. Probably another issue (de-ja-vue for me)
          Hide
          Marina Glancy added a comment -

          TO INTEGRATORS

          Please pick up additional commits in each branch. They address the following issues noticed by Fred:

          all versions: added moodle/course:update as an editing capability (it is needed for editing sections titles/summaries and also move sections in 2.3)
          2.3 capability moodle/course:movesections was not introduced yet, removed reference to it
          2.4 and above - there is an error in /course/view.php (most likely a result of simultaneous integration of MDL-34648 and MDL-28207) when BOTH capabilities course:update and course:movesections were checked to move a section. It was not visible before my changes because the control to move section was only shown if user had course:update capability.

          Show
          Marina Glancy added a comment - TO INTEGRATORS Please pick up additional commits in each branch. They address the following issues noticed by Fred: all versions: added moodle/course:update as an editing capability (it is needed for editing sections titles/summaries and also move sections in 2.3) 2.3 capability moodle/course:movesections was not introduced yet, removed reference to it 2.4 and above - there is an error in /course/view.php (most likely a result of simultaneous integration of MDL-34648 and MDL-28207) when BOTH capabilities course:update and course:movesections were checked to move a section. It was not visible before my changes because the control to move section was only shown if user had course:update capability.
          Hide
          Marina Glancy added a comment -

          btw Fred, reported by you: MDL-36465 Drag and drop a section to general section causes JS error

          Show
          Marina Glancy added a comment - btw Fred, reported by you: MDL-36465 Drag and drop a section to general section causes JS error
          Hide
          Dan Poltawski added a comment -

          Thanks Marina, i've integrated all of those.

          Back to you Fred.

          Show
          Dan Poltawski added a comment - Thanks Marina, i've integrated all of those. Back to you Fred.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          doh!

          Show
          Eloy Lafuente (stronk7) added a comment - doh!
          Hide
          Marina Glancy added a comment -

          TO INTEGRATORS: I know, I know, but please, pick up the last commit from all branches... Fred is doing really great job on testing!

          Show
          Marina Glancy added a comment - TO INTEGRATORS: I know, I know, but please, pick up the last commit from all branches... Fred is doing really great job on testing!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          doing...

          Show
          Eloy Lafuente (stronk7) added a comment - doing...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Uhm, 23_STABLE conflicting...

          index.php:
          
              ...
              ...
              $PAGE->set_pagetype('site-index');
          <<<<<<< HEAD
              $PAGE->set_other_editing_capability('moodle/course:manageactivities');
              $PAGE->set_other_editing_capability('moodle/course:activityvisibility');
          =======
          >>>>>>> FETCH_HEAD
              $PAGE->set_docs_path('');
              ...
              ...
          

          I bet it's safe to delete those 2 lines coz they are already some lines above, so resolving that way...

          Show
          Eloy Lafuente (stronk7) added a comment - Uhm, 23_STABLE conflicting... index.php: ... ... $PAGE->set_pagetype('site-index'); <<<<<<< HEAD $PAGE->set_other_editing_capability('moodle/course:manageactivities'); $PAGE->set_other_editing_capability('moodle/course:activityvisibility'); ======= >>>>>>> FETCH_HEAD $PAGE->set_docs_path(''); ... ... I bet it's safe to delete those 2 lines coz they are already some lines above, so resolving that way...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          done

          Show
          Eloy Lafuente (stronk7) added a comment - done
          Hide
          Frédéric Massart added a comment -

          Thanks guys, I'm passing the test, but I raised a couple of issues. Here is a summary of the related issues I've found, and if they were fixed or not:

          2.3

          • [OK] (front page) Missing capability moodle/course:movesections for non-editing teacher
          • MDL-40024 (front page) As a teacher without course:update, I can click the edit icon in course summary block, but that leads to an exception
          • [OK] (front page) As a non-editing teacher with the cap course:activityvisibility, I cannot hide an activity.
          • [OK] (front page) As a user with only course:update, I don't see the cog to edit the section
          • MDL-40026 (front page) As a non-editing teacher: Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible.
          • [OK] A user with only course:update cannot switch editing mode

          2.4

          • [OK] (front page) As a non-editing teacher with the cap course:activityvisibility, I can click the cog to edit a section, but that leads to an exception.
          • [OK] (front page) As a user with only course:update, I don't see the cog to edit the section
          • MDL-40026 (front page) As a non-editing teacher: Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible.
          • [OK] (front page) A user with only course:update cannot switch editing mode
          • [OK] A user with only course:update cannot switch editing mode

          2.5

          • MDL-40025 (front page) As a non-editing teacher, I can view the node 'Reports > Logs' but cannot access it:
          • MDL-40026 (front page) As a non-editing teacher: Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible.
          • [OK] A user with only course:update cannot switch editing mode
          Show
          Frédéric Massart added a comment - Thanks guys, I'm passing the test, but I raised a couple of issues. Here is a summary of the related issues I've found, and if they were fixed or not: 2.3 [OK] (front page) Missing capability moodle/course:movesections for non-editing teacher MDL-40024 (front page) As a teacher without course:update, I can click the edit icon in course summary block, but that leads to an exception [OK] (front page) As a non-editing teacher with the cap course:activityvisibility, I cannot hide an activity. [OK] (front page) As a user with only course:update, I don't see the cog to edit the section MDL-40026 (front page) As a non-editing teacher: Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible. [OK] A user with only course:update cannot switch editing mode 2.4 [OK] (front page) As a non-editing teacher with the cap course:activityvisibility, I can click the cog to edit a section, but that leads to an exception. [OK] (front page) As a user with only course:update, I don't see the cog to edit the section MDL-40026 (front page) As a non-editing teacher: Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible. [OK] (front page) A user with only course:update cannot switch editing mode [OK] A user with only course:update cannot switch editing mode 2.5 MDL-40025 (front page) As a non-editing teacher, I can view the node 'Reports > Logs' but cannot access it: MDL-40026 (front page) As a non-editing teacher: Navigation node 'Settings > Front page settings > Users > Permissions' is visible, but leads to denied access page. From a course, the page is accessible. [OK] A user with only course:update cannot switch editing mode
          Hide
          Dan Poltawski added a comment -
          Feature: Thanks to our superb contributors
            In order to make Moodle better
            As an integrator
            I need to thank all our contributors
          
            Scenario: Dan thanks you all
              Given I log in as "dan"
              And I see "lots of fixed issues"
              When I follow "Close integrated issues"
              Then I should see "Lots of thanks to all our contributors"
          

          Your changes are upstream

          Show
          Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream
          Hide
          Sam Hemelryk added a comment -

          This issue caused a regression in 2.4. See MDL-40236 for details.

          Show
          Sam Hemelryk added a comment - This issue caused a regression in 2.4. See MDL-40236 for details.

            People

            • Votes:
              12 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: