Non-editing teacher role cannot view/hide activities with permission set to allow.

The modification relates to items in course settings: Turn editing on/off Activity chooser on/off (visible only in editing mode, not available on frontpage) Edit course Create a course, add several modules in it Enrol one user with teacher role and one user with non-editing teacher role Also give two users those roles on frontpage Having default capabilities for roles, make sure that teacher can see all nodes listed above and non-editing teacher can see none (for both course and frontpage) Withdraw from teacher capability to edit course, give non-editing teacher capability course:activityvisibility Make sure teacher can not see node 'edit course' but can turn editing on and when editing is on he can manage activities (again, course and frontpage) Make sure non-editing teacher can turn editing on, does not see both other items and can show/hide modules Create a role with only course:update capability and no other course capabilities (awkward but still). Make sure user is able to switch editing mode on and edit sections (Note: In 2.3 there is no capability 'course:movesections' and in order to move sections capability 'course:update' is checked.) Will be really good if also can be tested when non-editing teacher has only capability to hide sections (revoke back activityvisibility) or capability to move sections. In 2.5+ (change not backported) non-editing teacher with only capability to set the current section should be able to do it but only in topics format. Sorry, all versions need to be tested separately (except 2.5/master is still on-sync).