Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      mnet is doing some non-standard theme tricks which needs evaluation and fixing

      This is a blocker issue:
      Administration > Networking > Peers > "a peer" > Click on the Theme tab
      => blank page
      It is due to a TO DO die() into http://cvs.moodle.org/moodle/admin/mnet/mnet_themes.php?view=markup

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              If I am reading the code right server administrator may assign a theme to each networked peer, then user coming from those peers get their theme.

              Changes:

              • instead of manually reading contents of $CFG->themedir we need to get list of theme plugins
              • get standard logo via pix_url
              • name and readme can be found through the ge_string()
              Show
              skodak Petr Skoda added a comment - If I am reading the code right server administrator may assign a theme to each networked peer, then user coming from those peers get their theme. Changes: instead of manually reading contents of $CFG->themedir we need to get list of theme plugins get standard logo via pix_url name and readme can be found through the ge_string()
              Hide
              filter manager Filter Manager added a comment -

              Mnet man, mnet man, please check this, mnet man!

              Show
              filter manager Filter Manager added a comment - Mnet man, mnet man, please check this, mnet man!
              Hide
              mudrd8mz David Mudrák added a comment -

              Fixed. The complex MNet peer theme selector page (duplicating the functionality of our Theme selector) replaced with a simple selecion element in Review host details form, which is enough for MNet purposes.

              Show
              mudrd8mz David Mudrák added a comment - Fixed. The complex MNet peer theme selector page (duplicating the functionality of our Theme selector) replaced with a simple selecion element in Review host details form, which is enough for MNet purposes.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    24/Nov/10