Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-20204 Themes 2.0: YUI, Caching, Performance, Consistency
  3. MDL-21143

prevent abusing of renderer factories, the component has to be always valid string

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      the problem is that people may try to specify non existent component and just hope the renderer finds the correct class somehow, this is a big potential problem

      we should prevent this by checking if the component matches any existing plugin

        Gliffy Diagrams

          Attachments

            Activity

            skodak Petr Skoda created issue -
            skodak Petr Skoda made changes -
            Field Original Value New Value
            Description the problem is that people may try to specify non existent component and just hope the renderer finds the correct class somehow, this is a big potential problem

            we should prevent this by checking if the component matches any existing plugin
            Hide
            skodak Petr Skoda added a comment -

            we will have to find some general solution how to extend core with more subtypes

            Show
            skodak Petr Skoda added a comment - we will have to find some general solution how to extend core with more subtypes
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Currently a renderer for any non-plugin code will be found as long as the dev has required the file containing the renderer in their code and asks for the appropriately named renderer.

            Show
            samhemelryk Sam Hemelryk added a comment - Currently a renderer for any non-plugin code will be found as long as the dev has required the file containing the renderer in their code and asks for the appropriately named renderer.
            Hide
            skodak Petr Skoda added a comment -

            done, I did some refactoring to get more improvements in
            see forum, lesson or webservice for more info

            Show
            skodak Petr Skoda added a comment - done, I did some refactoring to get more improvements in see forum, lesson or webservice for more info
            skodak Petr Skoda made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            dougiamas Martin Dougiamas made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            QA Assignee nobody
            dougiamas Martin Dougiamas made changes -
            Workflow jira [ 34494 ] MDL Workflow [ 63578 ]
            dougiamas Martin Dougiamas made changes -
            Workflow MDL Workflow [ 63578 ] MDL Full Workflow [ 92825 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10