Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21152

Add support for popup windows while maintaining xhtml compliance

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      xhtml doesnt support the target attribute on links. That means we can't use target=_blank for popups. We need another way to achieve the same effect.

      One possibility is this. http://articles.sitepoint.com/article/standards-compliant-world/3

      Probably use class=_blanktarget rather than rel=external to identify links wanting a new window. A single function that iterates over all links is probably better than lots of little bits of inline JS.

      Areas generating links that need consideration:
      convert_urls_into_links()
      help links
      messaging
      anything else?

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: