Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21159

Invalid HTML in the grader report

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.8
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      The <th> for the link to the user report is included inside the <th> for the username, which means that the columns do not line up.

      Also, It is hard-coded to use the user report, rather than respecting the $CFG->grade_profilereport setting.

      The attached patch fixes both of these.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              timhunt Tim Hunt added a comment -

              The bad HTML came from MDL-12972.

              Show
              timhunt Tim Hunt added a comment - The bad HTML came from MDL-12972 .
              Hide
              timhunt Tim Hunt added a comment -

              OK, fix checked in.

              Show
              timhunt Tim Hunt added a comment - OK, fix checked in.
              Hide
              andyjdavis Andrew Davis added a comment -

              Hi Tim. I've attached a patch that fixes other instances of the same problem that I spotted while QAing this. Would you mind giving it a quick look before I commit it (or committing it yourself if you prefer)?

              Show
              andyjdavis Andrew Davis added a comment - Hi Tim. I've attached a patch that fixes other instances of the same problem that I spotted while QAing this. Would you mind giving it a quick look before I commit it (or committing it yourself if you prefer)?
              Hide
              andyjdavis Andrew Davis added a comment -

              see my previous comment.

              Show
              andyjdavis Andrew Davis added a comment - see my previous comment.
              Hide
              timhunt Tim Hunt added a comment -

              Thank you for QAing this property. I should have checked more carefully. Please commit these changes.

              Show
              timhunt Tim Hunt added a comment - Thank you for QAing this property. I should have checked more carefully. Please commit these changes.
              Hide
              andyjdavis Andrew Davis added a comment -

              committed. marking as resolved.

              Show
              andyjdavis Andrew Davis added a comment - committed. marking as resolved.
              Hide
              mudrd8mz David Mudrák added a comment -

              Reviewed the commit. Closing.

              Show
              mudrd8mz David Mudrák added a comment - Reviewed the commit. Closing.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Mar/10