Moodle
  1. Moodle
  2. MDL-21159

Invalid HTML in the grader report

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.8
    • Component/s: Gradebook
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      The <th> for the link to the user report is included inside the <th> for the username, which means that the columns do not line up.

      Also, It is hard-coded to use the user report, rather than respecting the $CFG->grade_profilereport setting.

      The attached patch fixes both of these.

        Gliffy Diagrams

        1. Andrew_lib.patch.txt
          2 kB
          Andrew Davis
        2. grader_report.patch.txt
          2 kB
          Tim Hunt

          Issue Links

            Activity

            Hide
            Tim Hunt added a comment -

            The bad HTML came from MDL-12972.

            Show
            Tim Hunt added a comment - The bad HTML came from MDL-12972 .
            Hide
            Tim Hunt added a comment -

            OK, fix checked in.

            Show
            Tim Hunt added a comment - OK, fix checked in.
            Hide
            Andrew Davis added a comment -

            Hi Tim. I've attached a patch that fixes other instances of the same problem that I spotted while QAing this. Would you mind giving it a quick look before I commit it (or committing it yourself if you prefer)?

            Show
            Andrew Davis added a comment - Hi Tim. I've attached a patch that fixes other instances of the same problem that I spotted while QAing this. Would you mind giving it a quick look before I commit it (or committing it yourself if you prefer)?
            Hide
            Andrew Davis added a comment -

            see my previous comment.

            Show
            Andrew Davis added a comment - see my previous comment.
            Hide
            Tim Hunt added a comment -

            Thank you for QAing this property. I should have checked more carefully. Please commit these changes.

            Show
            Tim Hunt added a comment - Thank you for QAing this property. I should have checked more carefully. Please commit these changes.
            Hide
            Andrew Davis added a comment -

            committed. marking as resolved.

            Show
            Andrew Davis added a comment - committed. marking as resolved.
            Hide
            David Mudrak added a comment -

            Reviewed the commit. Closing.

            Show
            David Mudrak added a comment - Reviewed the commit. Closing.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: