Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21180

Category children default to extra credit when category agg is switched from Weighted to Simple

    Details

    • Testing Instructions:
      Hide

      NOTE: Following test should be run with default weight values. If weight is present then arrgregarecoef is not modified (to avoid data loss), while changing between the aggregation.

      1. Go to course with multiple activities
      2. Create grade category (C1)
      3. Set aggregation for C1 to Weighted Mean of Grades
      4. Check its children all have weights assigned to them
      5. Change C1 aggregation method to Simple weighted mean of grades
      6. Make sure children are not set extra credit
      7. Change C1 aggregation method to Weighted Mean of Grades
      8. Make sure children are set with weight 1.0
      9. Change C1 aggregation method to Mean of weight (With extra credit)
      10. Make sure children are set with weight 0.0
      11. Change C1 aggregation method to Sum of grades
      12. Make sure children are not set with extra credit
      13. Change C1 aggregation method to Weighted Mean of Grades
      14. Make sure children are set with weight 1.0

      Test 2

      – Run phpunit lib/grade/tests/grade_category_test.php

      Show
      NOTE: Following test should be run with default weight values. If weight is present then arrgregarecoef is not modified (to avoid data loss), while changing between the aggregation. Go to course with multiple activities Create grade category (C1) Set aggregation for C1 to Weighted Mean of Grades Check its children all have weights assigned to them Change C1 aggregation method to Simple weighted mean of grades Make sure children are not set extra credit Change C1 aggregation method to Weighted Mean of Grades Make sure children are set with weight 1.0 Change C1 aggregation method to Mean of weight (With extra credit) Make sure children are set with weight 0.0 Change C1 aggregation method to Sum of grades Make sure children are not set with extra credit Change C1 aggregation method to Weighted Mean of Grades Make sure children are set with weight 1.0 Test 2 – Run phpunit lib/grade/tests/grade_category_test.php
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      wip-mdl-21180
    • Story Points (Obsolete):
      40
    • Sprint:
      BACKEND Sprint 8

      Description

      Category 1 is set to Weighted Mean of Grades
      Its children all have weights assigned to them
      Category 1's agg method is switched to Simple weighted mean of grades
      Its chlldren are now all extra credit

      This was kinda, supposedly fixed with MDL-19407 but only took into account an item moved from a category of WM to SWM... not if the entire category is switched (common in our parts).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  19 Vote for this issue
                  Watchers:
                  20 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14