Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21180

Category children default to extra credit when category agg is switched from Weighted to Simple

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 1.9.5, 1.9.6, 1.9.7, 2.3.3, 2.4.3, 2.5
    • 2.4.8, 2.5.4, 2.6.1
    • Gradebook
    • Multiple
    • MOODLE_19_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • wip-mdl-21180
    • Hide

      NOTE: Following test should be run with default weight values. If weight is present then arrgregarecoef is not modified (to avoid data loss), while changing between the aggregation.

      1. Go to course with multiple activities
      2. Create grade category (C1)
      3. Set aggregation for C1 to Weighted Mean of Grades
      4. Check its children all have weights assigned to them
      5. Change C1 aggregation method to Simple weighted mean of grades
      6. Make sure children are not set extra credit
      7. Change C1 aggregation method to Weighted Mean of Grades
      8. Make sure children are set with weight 1.0
      9. Change C1 aggregation method to Mean of weight (With extra credit)
      10. Make sure children are set with weight 0.0
      11. Change C1 aggregation method to Sum of grades
      12. Make sure children are not set with extra credit
      13. Change C1 aggregation method to Weighted Mean of Grades
      14. Make sure children are set with weight 1.0

      Test 2

      – Run phpunit lib/grade/tests/grade_category_test.php

      Show
      NOTE: Following test should be run with default weight values. If weight is present then arrgregarecoef is not modified (to avoid data loss), while changing between the aggregation. Go to course with multiple activities Create grade category (C1) Set aggregation for C1 to Weighted Mean of Grades Check its children all have weights assigned to them Change C1 aggregation method to Simple weighted mean of grades Make sure children are not set extra credit Change C1 aggregation method to Weighted Mean of Grades Make sure children are set with weight 1.0 Change C1 aggregation method to Mean of weight (With extra credit) Make sure children are set with weight 0.0 Change C1 aggregation method to Sum of grades Make sure children are not set with extra credit Change C1 aggregation method to Weighted Mean of Grades Make sure children are set with weight 1.0 Test 2 – Run phpunit lib/grade/tests/grade_category_test.php
    • 40
    • BACKEND Sprint 8

    Description

      Category 1 is set to Weighted Mean of Grades
      Its children all have weights assigned to them
      Category 1's agg method is switched to Simple weighted mean of grades
      Its chlldren are now all extra credit

      This was kinda, supposedly fixed with MDL-19407 but only took into account an item moved from a category of WM to SWM... not if the entire category is switched (common in our parts).

      Attachments

        1. aggchangeextracredit022410.patch
          1.0 kB
          Bob Puffer
        2. extracredit_umn_RT57186.patch
          4 kB
          Elena Ivanova
        3. switchaggnoextracredit.patch
          1.0 kB
          Bob Puffer

        Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-43308 Grade aggregate coefficients should be handled separately

          • Minor - Minor loss of function where workaround is possible
          • Open
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-21596 Do not allow incompatible grade aggregation types

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36063 Extra credit boxes checked when switching aggregation methods

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              rajeshtaneja Rajesh Taneja
              bobpuffer Bob Puffer
              Dan Poltawski Dan Poltawski
              Sam Hemelryk Sam Hemelryk
              Damyon Wiese Damyon Wiese
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              19 Vote for this issue
              Watchers:
              20 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Jan/14