Moodle
  1. Moodle
  2. MDL-21225

Log display default action breaks URLs for plugins

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: BACKEND
    • Component/s: Course
    • Labels:
      None

      Description

      When the logs are displayed the URL is constructed using the make_log_url() function in course/lib.php. Unfortunately the module names are hard-coded in this function. This makes it impossible to add functionality for a plugin. The default activity for an unknown module name is to modify the URL with /mod/$module on the front which is only what you want in limited circumstances. The workaround is to pick a module type that does not munge the URL which means the log report is going to be less useful than it might have been.

        Gliffy Diagrams

          Activity

          Hide
          Michael de Raadt added a comment -

          This is likely to be resolved by the current events and logging re-write, but we shouldn't count our chickens before they hatch.

          Show
          Michael de Raadt added a comment - This is likely to be resolved by the current events and logging re-write, but we shouldn't count our chickens before they hatch.
          Hide
          Marina Glancy added a comment -

          This is fixed by Logging API introduced in 2.7
          Thanks

          Show
          Marina Glancy added a comment - This is fixed by Logging API introduced in 2.7 Thanks

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: