Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      1/ rename to "url" - those do not have to be only our urls, we can reference external things, there is no "url" collision with our shipped 3rd party libs

      2/ add new style of wwwroot relative urls "|course/view.php" - I hate typing $CFG->wwwroot over and over again, it would distinguish nicely from true relative links

      3/ there are some attempts to make url comparisons in our code - I doubt it works with relative urls, we can either make the comparing more clever or make the absolute urls already in constructor

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            after discussion with David we both agreed that all urls starting with "/" should be treated as relative to wwwroot such as "/course/view.php"
            also we should warn devs when using relative urls ( do not start with xxx: or /)

            Show
            skodak Petr Skoda added a comment - after discussion with David we both agreed that all urls starting with "/" should be treated as relative to wwwroot such as "/course/view.php" also we should warn devs when using relative urls ( do not start with xxx: or /)
            Hide
            dougiamas Martin Dougiamas added a comment -

            Decided not to rename the function - it's full of Moodle stuff.

            Show
            dougiamas Martin Dougiamas added a comment - Decided not to rename the function - it's full of Moodle stuff.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10