Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: MNet
    • Labels:
    • Difficulty:
      Difficult
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      1532

      Description

      Meta bug to help group 2.0 bugs

        Activity

        Penny Leach created issue -
        Penny Leach made changes -
        Field Original Value New Value
        Link This issue will help resolve MDL-21098 [ MDL-21098 ]
        Hide
        Petr Škoda added a comment -

        maybe we could get rid of the ugly $MNET global that is instantiated in the middle of library function, I say you already did something like that in portfolio code. The $MNET instance could be returned by some core function like "get_mnet_environment()" which would also load the general mnet library.

        see mnet/lib.php:

        $MNET = new mnet_environment();
        $MNET->init();
        
        Show
        Petr Škoda added a comment - maybe we could get rid of the ugly $MNET global that is instantiated in the middle of library function, I say you already did something like that in portfolio code. The $MNET instance could be returned by some core function like "get_mnet_environment()" which would also load the general mnet library. see mnet/lib.php: $MNET = new mnet_environment(); $MNET->init();
        Hide
        Penny Leach added a comment -

        Petr - that's being tracked in MDL-21276

        I also want to get rid of MNET_REMOTE_CLIENT global everywhere too, it's super ugly. It can't be passed around as a function argument (I commented on this somewhere else, can't remember where), but it can be encapsulated in get_mnet_remote_client() call.

        Show
        Penny Leach added a comment - Petr - that's being tracked in MDL-21276 I also want to get rid of MNET_REMOTE_CLIENT global everywhere too, it's super ugly. It can't be passed around as a function argument (I commented on this somewhere else, can't remember where), but it can be encapsulated in get_mnet_remote_client() call.
        Hide
        Penny Leach added a comment -

        Argh, there's also another global $MNETIDPJUMPURL

        Show
        Penny Leach added a comment - Argh, there's also another global $MNETIDPJUMPURL
        Hide
        Petr Škoda added a comment -

        David and Penny, what is the status of these issues?

        Show
        Petr Škoda added a comment - David and Penny, what is the status of these issues?
        Hide
        David Mudrak added a comment -

        Penny did a great job with organising these issues. Unfortunatelly, I won't be able to touch almost any of them until the second half of Sep so if 2.0 is really going to release by that time, the remaining issues here should be postponed to 2.1.

        Show
        David Mudrak added a comment - Penny did a great job with organising these issues. Unfortunatelly, I won't be able to touch almost any of them until the second half of Sep so if 2.0 is really going to release by that time, the remaining issues here should be postponed to 2.1.
        Martin Dougiamas made changes -
        Workflow jira [ 34648 ] MDL Workflow [ 45758 ]
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Moving this to the STABLE backlog... are there any plans? Do we need to fix any of them (really urgent/causing boom) for 2.0.x? Or can the whole thing be moved to DEV backlog?

        Show
        Eloy Lafuente (stronk7) added a comment - Moving this to the STABLE backlog... are there any plans? Do we need to fix any of them (really urgent/causing boom) for 2.0.x? Or can the whole thing be moved to DEV backlog?
        Eloy Lafuente (stronk7) made changes -
        Labels triaged
        Fix Version/s STABLE backlog [ 10463 ]
        Difficulty Difficult
        Hide
        David Mudrak added a comment -

        My +1 for moving all this to DEV backlog for 2.1. MNet needs some significant refactoring anyway (for example naming XMLRPC methods or the way how plugins can implement MNet interface).

        Show
        David Mudrak added a comment - My +1 for moving all this to DEV backlog for 2.1. MNet needs some significant refactoring anyway (for example naming XMLRPC methods or the way how plugins can implement MNet interface).
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Moving to DEV backlog, as requested. Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Moving to DEV backlog, as requested. Thanks!
        Eloy Lafuente (stronk7) made changes -
        Fix Version/s DEV backlog [ 10464 ]
        Fix Version/s STABLE backlog [ 10463 ]
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 45758 ] MDL Full Workflow [ 74085 ]
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Michael de Raadt added a comment -

        I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        This is being done as part of a bulk annual clean-up of issues.

        If you still believe this is an issue in supported versions, please create a new issue.

        Show
        Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.
        Michael de Raadt made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Penny Leach [ mjollnir ]
        Resolution Won't Fix [ 2 ]
        Fix Version/s DEV backlog [ 10464 ]

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: