Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21276

mnet shouldn't call mnet->init in global scope

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 1.9.8
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      taken from MDL-16565

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              mjollnir Penny Leach added a comment -

              partial dup of mdl-16565 but i want to close that one

              Show
              mjollnir Penny Leach added a comment - partial dup of mdl-16565 but i want to close that one
              Hide
              mjollnir Penny Leach added a comment -

              This is going to be a big thing to fix, I think.

              The best thing I guess is for me to just bite the bullet and do it and then run with mnet partially broken, fixing all places in code that rely on $MNET being initialised , as I find them.

              Show
              mjollnir Penny Leach added a comment - This is going to be a big thing to fix, I think. The best thing I guess is for me to just bite the bullet and do it and then run with mnet partially broken, fixing all places in code that rely on $MNET being initialised , as I find them.
              Hide
              mjollnir Penny Leach added a comment -

              I just committed a huge patch to head to address this. I need some help with testing. Adding Jerome as watcher to help with the repository stuff.

              Show
              mjollnir Penny Leach added a comment - I just committed a huge patch to head to address this. I need some help with testing. Adding Jerome as watcher to help with the repository stuff.
              Hide
              mjollnir Penny Leach added a comment -

              jerome can you please qa and close?

              Show
              mjollnir Penny Leach added a comment - jerome can you please qa and close?
              Hide
              jerome Jérôme Mouneyrac added a comment -

              that seems clean to me. I did some grep I didn't find anything weird ($MNET and mnet->init)
              I'm about to test the rep remote plugin... closing this issue.

              Show
              jerome Jérôme Mouneyrac added a comment - that seems clean to me. I did some grep I didn't find anything weird ($MNET and mnet->init) I'm about to test the rep remote plugin... closing this issue.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Mar/10