Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21294

change all error handling in mnet

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0
    • 2.0
    • MNet
    • None
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

    Description

      At the least, it should throw exceptions, which are caught by the error handler and used to send back a properly formatted xmlrpc response.

      Eg: mnet code does something like

      throw new mnet_exception(1234, get_string('blah', 'mnet')); // where 'blah' might be 'Your identity provider is not providing us enough information for your account to be created'

      and the default error handler, does something like if (defined('XMLRPC_MNET'))

      { xmlrpc_server_fault($e->getCode(), $e->getMessage()); }

      Will link in related bugs.

      Attachments

        Issue Links

          Activity

            People

              mjollnir Penny Leach
              mjollnir Penny Leach
              David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                24/Nov/10