Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21315

bug on highlighting grader report column

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.8
    • Component/s: Gradebook
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      when selecting a column in grader report, previous column will be highlighted instead of the selected one. The bug occurs when static students column (fixedstudents) is set to enable.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            rwijaya Rossiani Wijaya added a comment -

            attaching patch to fix the bug.

            Show
            rwijaya Rossiani Wijaya added a comment - attaching patch to fix the bug.
            Hide
            jrh18 Jason Hardin added a comment -

            I tried this patch and it doesn't fix the problem entirely. The cell index for the header is different than the cell index for the cells because the first ell has a colspan of 2. The patch makes the header highlight jump over by one. So the column is highlighted correctly but not the header. This probably works fine for gradebooks that don't' css stylize the header for the column but otherwise it will break. The javascript needs to be patched as well. I have a partial patch but i need to text it with fixed students.

            Show
            jrh18 Jason Hardin added a comment - I tried this patch and it doesn't fix the problem entirely. The cell index for the header is different than the cell index for the cells because the first ell has a colspan of 2. The patch makes the header highlight jump over by one. So the column is highlighted correctly but not the header. This probably works fine for gradebooks that don't' css stylize the header for the column but otherwise it will break. The javascript needs to be patched as well. I have a partial patch but i need to text it with fixed students.
            Hide
            jrh18 Jason Hardin added a comment -

            Attached is my patch. It heavily modifies the javascript and changes the original patch to pass increment to be used in the indexes for the cells.

            Show
            jrh18 Jason Hardin added a comment - Attached is my patch. It heavily modifies the javascript and changes the original patch to pass increment to be used in the indexes for the cells.
            Hide
            andyjdavis Andrew Davis added a comment -

            I've committed a fix for this. I didn't directly use your patch Jason but came up with something that should have the same effect.

            Sorry, I just realized that I forgot to create a patch before committing.

            Show
            andyjdavis Andrew Davis added a comment - I've committed a fix for this. I didn't directly use your patch Jason but came up with something that should have the same effect. Sorry, I just realized that I forgot to create a patch before committing.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Mar/10