Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21327

enrol/mnet creates users regardless of the auto create settings in auth/mnet

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: DEV backlog
    • Component/s: Enrolments, MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      Three options:

      • Change this case to throw an exception, so users have to have been created with auth/mnet before they're enrolled (this breaks BC)
      • Rely on the config settings from auth/mnet
      • Add a new config setting in enrol/mnet

      I think the first one is the "most correct" but I'm not sure....

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            jerome Jérôme Mouneyrac added a comment -

            There is something that I don't remember:

            In Moodle I went on :
            1- Administration > Courses > Enrolments
            there, we can enable Moodle Networking, and also edit. When we edit, we can not set any "user creation" operation (it is logic). I enabled this enrolment plugin.
            2- Administration > Authentication > Manage authentication > Moodle Network Authentication
            there, we can set 'Auto add remote users' to No.

            'Auto add remote users' is defined as: 'When set to Yes, a local user record is auto-created when a remote user logs in for the first time.'

            Does that means that when it's set to no, no local user record is created? Does that mean that Moodle has no remote user reference into the database?
            or maybe when a local user is auto-created that means that a user with the same username is created in local + we save a reference to the remote user ?

            I'm confused here because I don't see the point to this option. A remote user reference should always been saved into the database, so if the option is about to create a remote user reference, "create user" should always been set to Yes. Not settings it to Yes, it's about refusing any new enrolment, so to disable the network enrolment plugin.

            Show
            jerome Jérôme Mouneyrac added a comment - There is something that I don't remember: In Moodle I went on : 1- Administration > Courses > Enrolments there, we can enable Moodle Networking, and also edit. When we edit, we can not set any "user creation" operation (it is logic). I enabled this enrolment plugin. 2- Administration > Authentication > Manage authentication > Moodle Network Authentication there, we can set 'Auto add remote users' to No. 'Auto add remote users' is defined as: 'When set to Yes, a local user record is auto-created when a remote user logs in for the first time.' Does that means that when it's set to no, no local user record is created? Does that mean that Moodle has no remote user reference into the database? or maybe when a local user is auto-created that means that a user with the same username is created in local + we save a reference to the remote user ? I'm confused here because I don't see the point to this option. A remote user reference should always been saved into the database, so if the option is about to create a remote user reference, "create user" should always been set to Yes. Not settings it to Yes, it's about refusing any new enrolment, so to disable the network enrolment plugin.
            Hide
            jerome Jérôme Mouneyrac added a comment - - edited

            After talking with Penny, Penny conclude that the option auto-create was useful for this case:
            "if you have 100,000 users in site a, and you want 50 of them to be able to roam to site b, you could maybe upload a csv file to site b containing the 50 users and specifying their idp to be site a
            and then turn off the autocreateusers option
            so if any of the other users taht aren't in the 50 try to roam, they can't"

            I think the problem is not to disallow user creation, but to disallow enrolment
            "First the 50 guys must be enrolled on the site b, then the site b say he refuses any enrolment from site a" => we don't need any auto-creation option anymore

            Show
            jerome Jérôme Mouneyrac added a comment - - edited After talking with Penny, Penny conclude that the option auto-create was useful for this case: "if you have 100,000 users in site a, and you want 50 of them to be able to roam to site b, you could maybe upload a csv file to site b containing the 50 users and specifying their idp to be site a and then turn off the autocreateusers option so if any of the other users taht aren't in the 50 try to roam, they can't" I think the problem is not to disallow user creation, but to disallow enrolment "First the 50 guys must be enrolled on the site b, then the site b say he refuses any enrolment from site a" => we don't need any auto-creation option anymore
            Hide
            mjollnir Penny Leach added a comment -

            I made a thread 2 weeks ago on the network forum on moodle.org asking if anyone would be upset if we turned this off:

            http://moodle.org/mod/forum/discuss.php?d=141491

            And nobody answered. So I think the best thing to do is just remove that setting.

            Show
            mjollnir Penny Leach added a comment - I made a thread 2 weeks ago on the network forum on moodle.org asking if anyone would be upset if we turned this off: http://moodle.org/mod/forum/discuss.php?d=141491 And nobody answered. So I think the best thing to do is just remove that setting.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            +1 for no setting anymore.

            Show
            jerome Jérôme Mouneyrac added a comment - +1 for no setting anymore.
            Hide
            mjollnir Penny Leach added a comment -

            removed

            Show
            mjollnir Penny Leach added a comment - removed
            Hide
            mudrd8mz David Mudrak added a comment -

            Reopening. The setting is still mentioned around the code and some lang strings must be fixed, too. After reading the mentioned thread, I incline to keep this setting removed. Let us see how enrol_mnet will look like finally and then we can re-introduce this or similar setting again.

            Show
            mudrd8mz David Mudrak added a comment - Reopening. The setting is still mentioned around the code and some lang strings must be fixed, too. After reading the mentioned thread, I incline to keep this setting removed. Let us see how enrol_mnet will look like finally and then we can re-introduce this or similar setting again.
            Hide
            mudrd8mz David Mudrak added a comment -

            This issue was assigned to me, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            Show
            mudrd8mz David Mudrak added a comment - This issue was assigned to me, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: