Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-2133

'Login As' not fully functional with groups.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4.3
    • Fix Version/s: None
    • Component/s: Course
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_14_STABLE

      Description

      I noticed that the login as doesn't completely work with groups. This is because it only clears and sets the current courses group information. The problem is, that if I have other course group info cached, when I go to those courses, I'm not in the right group. Worse still, if I revert back to my original login in a different course, the group from the course I was in gets restored.

      I believe the code should be changes as in the attachment (look for '*** BUG' comments). That is, set and clear the entire group cache.

      mike

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            From Gustav Delius (gwd2 at york.ac.uk) Monday, 14 February 2005, 05:54 AM:

            Mike, this bug also confuses me occasionally. Are you planning to commit your fix for Moodle 1.5?

            From Mike Churchward (mike at churchward.ca) Wednesday, 16 February 2005, 04:06 AM:

            I can, but I was waiting (hoping) to hear if there was a reason that it was done the way it was. Something that isn't obvious.

            From Martin Dougiamas (martin at moodle.com) Wednesday, 16 February 2005, 11:27 AM:

            I can't remember why it was done that way ... I think your fix makes sense so please check it in

            From Mike Churchward (mike at churchward.ca) Wednesday, 16 February 2005, 09:43 PM:

            Done and committed.

            Show
            dougiamas Martin Dougiamas added a comment - From Gustav Delius (gwd2 at york.ac.uk) Monday, 14 February 2005, 05:54 AM: Mike, this bug also confuses me occasionally. Are you planning to commit your fix for Moodle 1.5? From Mike Churchward (mike at churchward.ca) Wednesday, 16 February 2005, 04:06 AM: I can, but I was waiting (hoping) to hear if there was a reason that it was done the way it was. Something that isn't obvious. From Martin Dougiamas (martin at moodle.com) Wednesday, 16 February 2005, 11:27 AM: I can't remember why it was done that way ... I think your fix makes sense so please check it in From Mike Churchward (mike at churchward.ca) Wednesday, 16 February 2005, 09:43 PM: Done and committed.
            Hide
            mblake Michael Blake added a comment -

            assign to a valid user

            Show
            mblake Michael Blake added a comment - assign to a valid user

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: