Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.8
    • Component/s: SCORM
    • Labels:
      None
    • Environment:
      LAMP, PHP 5.2.12
    • Database:
      MySQL
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      As stated in the summary, launching an AICC HACP item gets an annoying notice in the debugger level logs:

      ...
      [Mon Jan 11 15:53:29 2010] [error] [client 12.34.56.78] PHP Notice: Undefined property: stdClass::$parameters in /path/to/moodle/mod/scorm/loadSCO.php on line 87, referer: http://111.222.333.444/moodle/mod/scorm/player.php
      ...

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            matteo Matteo Scaramuccia added a comment -

            Fix proposal, loadSCO.php:

            @@ -78,10 +78,11 @@
                 }
             
                 if ($version == 'AICC') {
            +        $sco_params = '';
                     if (isset($sco->parameters) && (!empty($sco->parameters))) {
            -            $sco->parameters = '&'. $sco->parameters;
            +            $sco_params = '&'. $sco->parameters;
                     }
            -        $launcher = $sco->launch.$connector.'aicc_sid='.sesskey().'&aicc_url='.$CFG->wwwroot.'/mod/scorm/aicc.php'.$sco->parameters;
            +        $launcher = $sco->launch.$connector.'aicc_sid='.sesskey().'&aicc_url='.$CFG->wwwroot.'/mod/scorm/aicc.php'.$sco_params;
                 } else {
                     if (isset($sco->parameters) && (!empty($sco->parameters))) {
                         $launcher = $sco->launch.$connector.$sco->parameters;

            Show
            matteo Matteo Scaramuccia added a comment - Fix proposal, loadSCO.php : @@ -78,10 +78,11 @@ } if ($version == 'AICC') { + $sco_params = ''; if (isset($sco->parameters) && (!empty($sco->parameters))) { - $sco->parameters = '&'. $sco->parameters; + $sco_params = '&'. $sco->parameters; } - $launcher = $sco->launch.$connector.'aicc_sid='.sesskey().'&aicc_url='.$CFG->wwwroot.'/mod/scorm/aicc.php'.$sco->parameters; + $launcher = $sco->launch.$connector.'aicc_sid='.sesskey().'&aicc_url='.$CFG->wwwroot.'/mod/scorm/aicc.php'.$sco_params; } else { if (isset($sco->parameters) && (!empty($sco->parameters))) { $launcher = $sco->launch.$connector.$sco->parameters;
            Hide
            danmarsden Dan Marsden added a comment -

            fix now in 1.9Stable and Head - thanks for the great report and fix!

            Show
            danmarsden Dan Marsden added a comment - fix now in 1.9Stable and Head - thanks for the great report and fix!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Mar/10