Moodle
  1. Moodle
  2. MDL-21353

Review mode is potentially a big issue in real life tracked items delivering

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Duplicate
    • Affects Version/s: 1.9.7
    • Fix Version/s: 2.0
    • Component/s: SCORM
    • Labels:
      None
    • Environment:
      LAMP, PHP 5.2.12
    • Database:
      MySQL
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      33982

      Description

      We're using Moodle to deliver many old AICC HACP courses, each of them based on just Mastery Score feature i.e. the status of each item passes from incomplete to failed/passed according with score being under/over mastery score.
      The default review business logic is somewhat a PITA for us since a user that failed a test will be not able to pass it even if his/her score will be over the mastery score, unless the user will start a new attempt, which is fine but not what our users expect to do: they just click over the title of an item, on average.

      We kindly ask to add a new configuration parameter in order to enable such review behaviour, being by default enabled for backward compatibility.

        Issue Links

          Activity

          Matteo Scaramuccia created issue -
          Hide
          Matteo Scaramuccia added a comment -

          Patch proposal: it misses english strings and correct DB update procedure (table mdl_scorm, column enablereview, default value 1), waiting for any feedback about the proposal.

          lang/it_utf8/scorm.php

          @@ -49,6 +49,8 @@
           $string['displaydesc'] = 'Questa preferenza imposta il valore di default per la visualizzazione di un pacchetto';
           $string['domxml'] = 'Libreria esterna DOMXML';
           $string['element'] = 'Elemento';
          +$string['enablereview'] = 'Abilita l\'opzione Revisione';
          +$string['enablereviewdesc'] = 'Questa preferenza imposta il valore di default per l\'abilitazione o disabilitazione della modalità revisione';
           $string['enter'] = 'Entra';
           $string['entercourse'] = 'Entra nel corso';
           $string['errorlogs'] = 'Log degli errori';
          

          mod/scorm/mod_form.php

          @@ -130,6 +130,12 @@
                   $mform->setHelpButton('hidebrowse', array('hidebrowse',get_string('hidebrowse', 'scorm'), 'scorm'));
                   $mform->setDefault('hidebrowse', $CFG->scorm_hidebrowse);
                   $mform->setAdvanced('hidebrowse');
          +        
          +// Enable Review
          +        $mform->addElement('selectyesno', 'enablereview', get_string('enablereview', 'scorm'));
          +        $mform->setHelpButton('enablereview', array('enablereview',get_string('enablereview', 'scorm'), 'scorm'));
          +        $mform->setDefault('enablereview', $CFG->scorm_enablereview);
          +        $mform->setAdvanced('enablereview');        
           
           // Toc display
                   $mform->addElement('select', 'hidetoc', get_string('hidetoc', 'scorm'), scorm_get_hidetoc_array());
          

          mod/scorm/player.php

          @@ -91,11 +91,15 @@
               }
               if ($mode != 'browse') {
                   if ($trackdata = scorm_get_tracks($sco->id,$USER->id,$attempt)) {
          -            if (($trackdata->status == 'completed') || ($trackdata->status == 'passed') || ($trackdata->status == 'failed')) {
          -                $mode = 'review';
          -            } else {
          -                $mode = 'normal';
          -            }
          +            if ($scorm->enablereview == 1) {
          +			    if (($trackdata->status == 'completed') || ($trackdata->status == 'passed') || ($trackdata->status == 'failed')) {
          +                    $mode = 'review';
          +                } else {
          +                    $mode = 'normal';
          +                }
          +			} else {
          +			    $mode = 'normal';
          +			}
                   } else {
                       $mode = 'normal';
                   }
          

          mod/scorm/settings.php

          @@ -32,6 +32,8 @@
           
           $settings->add(new admin_setting_configselect('scorm_hidebrowse', get_string('hidebrowse', 'scorm'), get_string('hidebrowsedesc', 'scorm'), 0, $yesno));
           
          +$settings->add(new admin_setting_configselect('scorm_enablereview', get_string('enablereview', 'scorm'), get_string('enablereviewdesc', 'scorm'), 0, $yesno));
          +
           $settings->add(new admin_setting_configselect('scorm_hidetoc', get_string('hidetoc', 'scorm'), get_string('hidetocdesc', 'scorm'), 0, scorm_get_hidetoc_array()));
           
           $settings->add(new admin_setting_configselect('scorm_hidenav', get_string('hidenav', 'scorm'), get_string('hidenavdesc', 'scorm'), 0, $yesno));
          
          Show
          Matteo Scaramuccia added a comment - Patch proposal: it misses english strings and correct DB update procedure (table mdl_scorm , column enablereview , default value 1 ), waiting for any feedback about the proposal. lang/it_utf8/scorm.php @@ -49,6 +49,8 @@ $string['displaydesc'] = 'Questa preferenza imposta il valore di default per la visualizzazione di un pacchetto'; $string['domxml'] = 'Libreria esterna DOMXML'; $string['element'] = 'Elemento'; +$string['enablereview'] = 'Abilita l\'opzione Revisione'; +$string['enablereviewdesc'] = 'Questa preferenza imposta il valore di default per l\'abilitazione o disabilitazione della modalità revisione'; $string['enter'] = 'Entra'; $string['entercourse'] = 'Entra nel corso'; $string['errorlogs'] = 'Log degli errori'; mod/scorm/mod_form.php @@ -130,6 +130,12 @@ $mform->setHelpButton('hidebrowse', array('hidebrowse',get_string('hidebrowse', 'scorm'), 'scorm')); $mform->setDefault('hidebrowse', $CFG->scorm_hidebrowse); $mform->setAdvanced('hidebrowse'); + + // Enable Review + $mform->addElement('selectyesno', 'enablereview', get_string('enablereview', 'scorm')); + $mform->setHelpButton('enablereview', array('enablereview',get_string('enablereview', 'scorm'), 'scorm')); + $mform->setDefault('enablereview', $CFG->scorm_enablereview); + $mform->setAdvanced('enablereview'); // Toc display $mform->addElement('select', 'hidetoc', get_string('hidetoc', 'scorm'), scorm_get_hidetoc_array()); mod/scorm/player.php @@ -91,11 +91,15 @@ } if ($mode != 'browse') { if ($trackdata = scorm_get_tracks($sco->id,$USER->id,$attempt)) { - if (($trackdata->status == 'completed') || ($trackdata->status == 'passed') || ($trackdata->status == 'failed')) { - $mode = 'review'; - } else { - $mode = 'normal'; - } + if ($scorm->enablereview == 1) { + if (($trackdata->status == 'completed') || ($trackdata->status == 'passed') || ($trackdata->status == 'failed')) { + $mode = 'review'; + } else { + $mode = 'normal'; + } + } else { + $mode = 'normal'; + } } else { $mode = 'normal'; } mod/scorm/settings.php @@ -32,6 +32,8 @@ $settings->add( new admin_setting_configselect('scorm_hidebrowse', get_string('hidebrowse', 'scorm'), get_string('hidebrowsedesc', 'scorm'), 0, $yesno)); +$settings->add( new admin_setting_configselect('scorm_enablereview', get_string('enablereview', 'scorm'), get_string('enablereviewdesc', 'scorm'), 0, $yesno)); + $settings->add( new admin_setting_configselect('scorm_hidetoc', get_string('hidetoc', 'scorm'), get_string('hidetocdesc', 'scorm'), 0, scorm_get_hidetoc_array())); $settings->add( new admin_setting_configselect('scorm_hidenav', get_string('hidenav', 'scorm'), get_string('hidenavdesc', 'scorm'), 0, $yesno));
          Dan Marsden made changes -
          Field Original Value New Value
          Link This issue duplicates MDL-11501 [ MDL-11501 ]
          Hide
          Dan Marsden added a comment -

          Hi Matteo,

          changes to the database structure are avoided in stable releases - check out MDL-11501 which has a range of changes around review mode etc and is already in 2.0

          thanks!

          Show
          Dan Marsden added a comment - Hi Matteo, changes to the database structure are avoided in stable releases - check out MDL-11501 which has a range of changes around review mode etc and is already in 2.0 thanks!
          Dan Marsden made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 2.0 [ 10122 ]
          Resolution Duplicate [ 3 ]
          Martin Dougiamas made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          QA Assignee nobody
          Martin Dougiamas made changes -
          Workflow jira [ 34781 ] MDL Workflow [ 63703 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 63703 ] MDL Full Workflow [ 92954 ]
          Hide
          Salim Šabi? added a comment -

          I have lot of courses and all of them are filled with SCORM, the lessons are no problem, but when a user goes to a Quiz, the first attempt is ok, the Quiz shows up just as it should, but if a student fails the exam, (eg. the pass score is 60% and a student scores 50% or 40% or 3%), and closes the Quiz.

          If the student wants to retake, or reatempt the Quiz, it appears in Review Mode, no matter what I do, this keeps going on. I tried the Grade editing in the course grades options, changed the SCORM option to disable the Preview mode as default, but nothing changes.

          The case is, I did not just upgrade from 1.9.2. to 1.9.12., but also we did a migration from a old to a new Server and then did the upgrade. Maybe this could case the troubles. But I truly don't see why and how this could happen.

          But the problem has been resolved in this thread: http://moodle.org/mod/forum/discuss.php?d=181934

          Thanks again.

          Show
          Salim Šabi? added a comment - I have lot of courses and all of them are filled with SCORM, the lessons are no problem, but when a user goes to a Quiz, the first attempt is ok, the Quiz shows up just as it should, but if a student fails the exam, (eg. the pass score is 60% and a student scores 50% or 40% or 3%), and closes the Quiz. If the student wants to retake, or reatempt the Quiz, it appears in Review Mode, no matter what I do, this keeps going on. I tried the Grade editing in the course grades options, changed the SCORM option to disable the Preview mode as default, but nothing changes. The case is, I did not just upgrade from 1.9.2. to 1.9.12., but also we did a migration from a old to a new Server and then did the upgrade. Maybe this could case the troubles. But I truly don't see why and how this could happen. But the problem has been resolved in this thread: http://moodle.org/mod/forum/discuss.php?d=181934 Thanks again.
          Hide
          Dan Marsden added a comment -

          Hi Salim - this site is for reporting bugs with Moodle - your question is really related to SCORM authoring (although we have features in 2.0 that allow you to control this for buggy scorm packages.)

          If you don't want to upgrade to 2.0 I suggest you ask for further help in the discussion you linked to.

          Show
          Dan Marsden added a comment - Hi Salim - this site is for reporting bugs with Moodle - your question is really related to SCORM authoring (although we have features in 2.0 that allow you to control this for buggy scorm packages.) If you don't want to upgrade to 2.0 I suggest you ask for further help in the discussion you linked to.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: