Moodle
  1. Moodle
  2. MDL-21356

RSSlib should escape category domain

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.9.7
    • Fix Version/s: 1.9.8
    • Component/s: RSS
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      26533

      Description

      Note: The bug here is with code I wrote! This is related to MDL-19274 about including tag information with blog posts.

      The ->tagscheme field in RSS $item is a URL. If the URL contains an & symbol, this needs to be escaped in output, otherwise the RSS library generates invalid XML. My code forgot to escape it.

      It is very unlikely that this would ever cause an actual problem in standard moodle install because the value used for tagscheme is always "$CFG->wwwroot/tag", so unless you have an & inside your wwwroot (which is quite difficult to achieve) there will not be a problem. However this causes an issue for oublog which uses a feed url, which might include &, for its tagscheme.

      Since it is still a bug (albeit one very unlikely to occur) and since fixing it is harmless, I'm going to commit this simple fix to stable (after testing it with use of standard moodle blog).

        Activity

        Hide
        Sam Marshall added a comment -

        Done. I tested by checking the core blog RSS output of posts with tags (unchanged) and the oublog thing which was breaking (works now). Mind, not sure oublog should be doing that in the first place, but that's a matter for oublog...

        (changed file: lib/rsslib.php)

        Show
        Sam Marshall added a comment - Done. I tested by checking the core blog RSS output of posts with tags (unchanged) and the oublog thing which was breaking (works now). Mind, not sure oublog should be doing that in the first place, but that's a matter for oublog... (changed file: lib/rsslib.php)

          People

          • Assignee:
            Sam Marshall
            Reporter:
            Sam Marshall
            Tester:
            Nobody
            Participants:
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: