Moodle
  1. Moodle
  2. MDL-21440

Hardcoded strings in "admin/settings/security.php"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.7, 2.0
    • Fix Version/s: 1.9.8
    • Component/s: Administration, Language
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      26548

      Description

      Lines 75-77 of file "admin/settings/security.php" contains three hardcoded strings: 'No courses', 'All courses' and 'Requested courses'.

      These should be localised.

        Activity

        Hide
        Rossiani Wijaya added a comment -

        Thank you Nicolas for reporting the bug.

        created patch for the bug.

        also, adding Sam as a watcher and to review the patch.

        Show
        Rossiani Wijaya added a comment - Thank you Nicolas for reporting the bug. created patch for the bug. also, adding Sam as a watcher and to review the patch.
        Hide
        Rossiani Wijaya added a comment -

        committed to 1.9.8 and Stable.

        Show
        Rossiani Wijaya added a comment - committed to 1.9.8 and Stable.
        Hide
        Rossiani Wijaya added a comment -

        Hi Helen,

        I added and committed 2 simple strings to en_utf8/moodle.php.

        $string['nocourses'] = 'No courses';
        $string['requestedcourses'] = 'Requested courses';

        Please take a look and let me know if it needs to be change.

        Thank you
        Rosie

        Show
        Rossiani Wijaya added a comment - Hi Helen, I added and committed 2 simple strings to en_utf8/moodle.php. $string ['nocourses'] = 'No courses'; $string ['requestedcourses'] = 'Requested courses'; Please take a look and let me know if it needs to be change. Thank you Rosie
        Hide
        Helen Foster added a comment -

        Looks perfect, thanks Rosie.

        Just removing 2.0 from the fix version for this issue, as instructions state "Do not include the current HEAD version unless it's the only one."

        Show
        Helen Foster added a comment - Looks perfect, thanks Rosie. Just removing 2.0 from the fix version for this issue, as instructions state "Do not include the current HEAD version unless it's the only one."
        Hide
        Andrew Davis added a comment -

        Looks good. Closing.

        Helen is correct, the fix version should only contain the first version the issue was fixed in. If its fixed in 1.9.8 its assumed that it is fixed in 1.9.9, 2 and any other version after 1.9.8

        Show
        Andrew Davis added a comment - Looks good. Closing. Helen is correct, the fix version should only contain the first version the issue was fixed in. If its fixed in 1.9.8 its assumed that it is fixed in 1.9.9, 2 and any other version after 1.9.8

          People

          • Votes:
            4 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: