Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21446

Excel export does not work with >31 character worksheet names

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.7, 1.9.11, 2.0.2
    • Fix Version/s: 1.9.12, 2.0.3
    • Component/s: Libraries
    • Labels:
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      In latin 1 mode, the PEAR library throws an error when a sheet name is longer than 31 chars.

      In Unicode mode, the PEAR libarary thinks that longer sheet names will work, but we are getting errors when we try to open those files in Excel.

      I propose to truncate all worksheet names to 31 chars max in excellib.

      I am about to check this change into OU Moodle. please review and decide if you want it in 1.9 and or HEAD.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Grrr! this has been just sitting here for a year. I'll put it into git, and see if that make anyone more inclined to comment.

            Show
            timhunt Tim Hunt added a comment - Grrr! this has been just sitting here for a year. I'll put it into git, and see if that make anyone more inclined to comment.
            Hide
            timhunt Tim Hunt added a comment -
            Show
            timhunt Tim Hunt added a comment - OK. https://github.com/timhunt/moodle/compare/master...MDL-21446 - for comment.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Doh, my fault Tim, apologizes

            I had this completely lost in all my lists. Thanks for pinging!

            I've left this open in my browser so will look to it tomorrow!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Doh, my fault Tim, apologizes I had this completely lost in all my lists. Thanks for pinging! I've left this open in my browser so will look to it tomorrow! Ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            +1

            Assigning to Tim as commented @ HQ. Thanks!!!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - +1 Assigning to Tim as commented @ HQ. Thanks!!!
            Hide
            timhunt Tim Hunt added a comment -

            Pull requests done.

            One way to test this is to make a quiz with long question names. Then do several attempts, then go the the quiz statistics report, and choose "Download entire report as Excel". You should find you get a spreadsheet with worksheet names truncated to 31 chars.

            Show
            timhunt Tim Hunt added a comment - Pull requests done. One way to test this is to make a quiz with long question names. Then do several attempts, then go the the quiz statistics report, and choose "Download entire report as Excel". You should find you get a spreadsheet with worksheet names truncated to 31 chars.
            Hide
            tsala Helen Foster added a comment -

            Thanks for fixing Tim.

            Show
            tsala Helen Foster added a comment - Thanks for fixing Tim.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/May/11