[MDL-21475] regular expression for email validation - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

No human testing required, just unit tests

Show
No human testing required, just unit tests
Affected Branches:
MOODLE_19_STABLE, MOODLE_23_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_37_STABLE
Pull from Repository:
https://github.com/arjenlentz/moodle
Pull Master Branch:
arjen_validate_email
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/12499956...arjenlentz:arjen_validate_email

the current regular expression for valid_email function (lib/weblib.php) does not validate the domain name accordingly.

I proposed for modifying the regular expression so it matches the RFC specification.

proposed new regular expression:

preg_match('#^([^\.]([\!\#\$\%\&\'\*\+\-\/=\?\^\_`\{\|\}\~a-z0-9]+\.)*' .

                '[\!\#\$\%\&\'\*\+\-\/=\?\^\_`\{\|\}\~a-z0-9]+)' .

                '@' .

                '(([a-z0-9\_\-]{1,64}\.)*[a-z0-9\_\-]{1,64})$#i',

                $address);

has a non-specific relationship to

MDL-57567 validate_email incorrectly allows repeated dots.

is duplicated by

MDL-36788 Error in function validate_email()

MDL-57567 validate_email incorrectly allows repeated dots.

Estimated:

Remaining:

Logged: