Moodle
  1. Moodle
  2. MDL-26697 mediaplugin fixes and improvements META
  3. MDL-21491

YouTube filter - "wmode" makes player inaccessible to keyboard users

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.6, 1.9.7, 2.0
    • Fix Version/s: 2.0.3
    • Component/s: Accessibility, Filters
    • Labels:
      None
    • Environment:
      Windows XP/Firefox 3.6; Windows/MSIE 7... (note, a wider, non-Moodle bug makes Flash inaccessible in Mac OS X/Firefox 3.6).
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The parameter values "transparent" and "opaque" (that is, not the default "window") prevent keyboard users from using the TAB key to access and control embedded objects. Please see my blog post for details and related links, "Flash wmode considered harmful" (September 2009), http://freear.org.uk/node/22 - as I note there, most content creators/sites do not need "transparent" Flash objects (and the YouTube embed code does not contain it), so removing this parameter should not be an issue.

      I have found the related bugs/issues MDL-5938 "Transparent background for swf", and MDL-19231"Add filter to process YouTube..." (Moodle 1.9).

      The solution is to remove the following line in function "mediaplugin_filter_youtube_callback", in filter/mediaplugin/filter.php:

      <param name="wmode" value="transparent" />

      Patch to follow. Yours,

      Nick

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Nick Freear added a comment -

            I'm attaching a 1-line patch, which removes the "wmode" parameter, and inserts a PHP comment referencing this bug - affects 1 file, as per the bug report.

            I'm happy to apply this patch, if no one objects.

            Thanks

            Nick

            Show
            Nick Freear added a comment - I'm attaching a 1-line patch, which removes the "wmode" parameter, and inserts a PHP comment referencing this bug - affects 1 file, as per the bug report. I'm happy to apply this patch, if no one objects. Thanks Nick
            Hide
            Nick Freear added a comment -

            I don't think the patch for MDL-5938 (to add "wmode" in a 2nd place) should be applied.
            N.

            Show
            Nick Freear added a comment - I don't think the patch for MDL-5938 (to add "wmode" in a 2nd place) should be applied. N.
            Hide
            Petr Skoda added a comment -

            The wmode parameter was removed, thanks for the report.

            Petr

            Show
            Petr Skoda added a comment - The wmode parameter was removed, thanks for the report. Petr
            Hide
            Nick Freear added a comment -

            Thank you Petr.

            BTW, has Git become the primary source control for core Moodle?

            Yours,

            Nick

            Show
            Nick Freear added a comment - Thank you Petr. BTW, has Git become the primary source control for core Moodle? Yours, Nick
            Hide
            Petr Skoda added a comment -

            Yes, we switched to git around last Christmas.

            Show
            Petr Skoda added a comment - Yes, we switched to git around last Christmas.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: