Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21645

update the rest of admin/mnet to new standards

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      Quick list:

      • Completed:

      delete.php
      peers.php
      peer_forms.php
      profilefields.php
      profileform.php
      services_form.php
      services.php
      tabs.php
      testclient.php

      • Not completed:

      access_control.php - should be switched to using moodle forms, needs proper doc template at the top
      enr_hosts.php - prints a list of all hosts that can accept mnet enrolments. Should be switched to html_table and needs proper doc template at the top
      enr_courses.php - prints a list of all remote courses for a given host. Should be switched to html_table and needs proper doc template at the top

      enr_course_enrol.php - prints the two drop down menus to enrol/unenrol students on a single course on a remote host
      enr_course_enrol.html - contains the form definition

      These two should be merged and use a moodle form instead. There is inline sql rather than a libary call and both are lacking doc templates at the top.

      index.php - displays the current key and allows the user to delete it. Seems to contain two different forms, maybe because previously the networking on/off setting was on this page too. Needs to be migrated to new OUTPUT single button stuff and needs proper doc template at the top.

      mnet_themes.html
      mnet_themes.php

      Completely disabled - have die() at the top (still in tabs.php though !!)

      trustedhosts.php
      trustedhosts.html

      These two seems to be to make a list of host ips to allow plaintext (not normal encrypted MNET connections) from. It should possibly be removed, and at any rate, migrated to an moodle form. Needs proper doc template at the top.

      I would also consider renaming some of those files:

      enr_hosts.php to enrol/hosts.php
      enr_courses.php to enrol/courses.php
      enr_course_enrol.php to enrol/enrol.php

      If kept, mnet_themes* should be renamed to just themes* (I did this already with services.php)

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: