Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-21845

[PATCH] Multilang filter is not applied to custom field labels in user profile

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.7, 2.0
    • Fix Version/s: 1.8.13, 1.9.9, 2.0
    • Component/s: Filters
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      Summary says it all. Also see discussion here: http://moodle.org/mod/forum/discuss.php?d=146074

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              mina Nicolas Martignoni added a comment -

              Analog issue, already fixed.

              Show
              mina Nicolas Martignoni added a comment - Analog issue, already fixed.
              Hide
              mudrd8mz David Mudrák added a comment -

              Please make sure you have enabled Site Administration > Modules > Filters > Manage filters > Filter all strings. Once you do it, custom field name will be correctly displayed in the user profile form. There is still a small bug when displaying a list of all custom fields and I will fix that one.

              Show
              mudrd8mz David Mudrák added a comment - Please make sure you have enabled Site Administration > Modules > Filters > Manage filters > Filter all strings. Once you do it, custom field name will be correctly displayed in the user profile form. There is still a small bug when displaying a list of all custom fields and I will fix that one.
              Hide
              mudrd8mz David Mudrák added a comment -

              The attached patch fixes multilang support at the page Site Administration > Users > Accounts > User profile fields

              Show
              mudrd8mz David Mudrák added a comment - The attached patch fixes multilang support at the page Site Administration > Users > Accounts > User profile fields
              Hide
              mudrd8mz David Mudrák added a comment -

              We have code freeze now so I can't commit the patch right now. I will do it next week after 1.9.8 release.

              Show
              mudrd8mz David Mudrák added a comment - We have code freeze now so I can't commit the patch right now. I will do it next week after 1.9.8 release.
              Hide
              mudrd8mz David Mudrák added a comment -

              Fixed in CVS. Upgrade to the next weekly build to get this fixed on your servers. Thanks for the report.

              Show
              mudrd8mz David Mudrák added a comment - Fixed in CVS. Upgrade to the next weekly build to get this fixed on your servers. Thanks for the report.
              Hide
              lucas.sa Lucas Sa added a comment -

              The bug was not totally resolved with the previous patch.
              The user that reported the bug was referring to i18n on user profile view, as in the last comments on:

              http://moodle.org/mod/forum/discuss.php?d=146074

              user/view.php?id= ...

              This page uses the function profile_display_fields() on /user/profile/lib.php
              I am attaching a patch, but I am not sure if this format works, so basically I changed the line 418 (inside function profile_display_fields()):

              print_row(s($formfield->field->name.':'), $formfield->display_data());

              for

              print_row(s(format_string($formfield->field->name).':'), $formfield->display_data());

              Since this bug is marked as Resolved, I am not sure if it is going to be published in CVS.

              Show
              lucas.sa Lucas Sa added a comment - The bug was not totally resolved with the previous patch. The user that reported the bug was referring to i18n on user profile view, as in the last comments on: http://moodle.org/mod/forum/discuss.php?d=146074 user/view.php?id= ... This page uses the function profile_display_fields() on /user/profile/lib.php I am attaching a patch, but I am not sure if this format works, so basically I changed the line 418 (inside function profile_display_fields()): print_row(s($formfield->field->name.':'), $formfield->display_data()); for print_row(s(format_string($formfield->field->name).':'), $formfield->display_data()); Since this bug is marked as Resolved, I am not sure if it is going to be published in CVS.
              Hide
              mudrd8mz David Mudrák added a comment -

              Right - the patch fixed just the part where the field labels are defined, not the user profile display. Reopening. Thanks for the report.

              Show
              mudrd8mz David Mudrák added a comment - Right - the patch fixed just the part where the field labels are defined, not the user profile display. Reopening. Thanks for the report.
              Hide
              mudrd8mz David Mudrák added a comment -

              Fixed in 1.8, 1.9 and HEAD. Thanks for the report.

              Show
              mudrd8mz David Mudrák added a comment - Fixed in 1.8, 1.9 and HEAD. Thanks for the report.

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    8/Jun/10