Moodle
  1. Moodle
  2. MDL-21939

Student gradebook table is malformed when a category is hidden

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.8
    • Fix Version/s: None
    • Component/s: Gradebook
    • Labels:
      None
    • Environment:
      n/a
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      When gradebook categories are setup, with nested categories, e.g.

      Course
      ---Unit 1
      ------Unit 1 Graded
      ------Unit 1 Ungraded
      ------Unit 1 Test
      ---Unit 2
      ------Unit 2 Graded
      ------Unit 2 Ungraded
      ------Unit 2 Test

      The student gardebook reflects this structure. Specifically, the parent categories ('Unit 1' and 'Unit 2') have leading cells that have a rowspan value that means the child categories are visually contained within the parent.

      However...

      If one of the sub-categories (e.g. 'Unit 1 Ungraded') is hidden by the teacher, the student gradebook becomes malformed. The parent category (in this case 'Unit 1') has a leading cell rowspan value that includes the hidden child category, even though the child cells are not shown. This incorrect rowspan value deforms the remainder of the gradebook table.

      This has been discussed in the forums (where there are screenshots showing the issue), where I've also posted a patch...

      http://moodle.org/mod/forum/discuss.php?d=142229#p641882

      (This seems are very visible bug, yet I couldn't find it in the Tracker, nor many mentions in the forums - strange!)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael Woods added a comment -

            Hi,

            We are certainly having this issue also. We are a K-12 school that has most gradebooks split into Semester 1 / Semester 2 - almost exactly as Steve has described.

            The fix supplied seems to be fairly logical and straight-forward. Any action on this one?

            Thanks,
            Michael

            Show
            Michael Woods added a comment - Hi, We are certainly having this issue also. We are a K-12 school that has most gradebooks split into Semester 1 / Semester 2 - almost exactly as Steve has described. The fix supplied seems to be fairly logical and straight-forward. Any action on this one? Thanks, Michael
            Hide
            Michael Woods added a comment -

            Had already created a tracker item for this one in Nov 2010. A few watches and votes on that one too.

            Show
            Michael Woods added a comment - Had already created a tracker item for this one in Nov 2010. A few watches and votes on that one too.
            Hide
            Andrew Davis added a comment -

            I'm not sure when exactly but we appear to have fixed this bug.

            Also, bug fixing for non-security bugs in 1.9 has ended. http://docs.moodle.org/dev/Releases#Moodle_1.9

            I strongly recommend that anyone using 1.9 upgrade as soon as possible.

            I do not believe this issue is present in more recent versions of Moodle however if I am incorrect please open a new issue against the version you are using.

            Show
            Andrew Davis added a comment - I'm not sure when exactly but we appear to have fixed this bug. Also, bug fixing for non-security bugs in 1.9 has ended. http://docs.moodle.org/dev/Releases#Moodle_1.9 I strongly recommend that anyone using 1.9 upgrade as soon as possible. I do not believe this issue is present in more recent versions of Moodle however if I am incorrect please open a new issue against the version you are using.
            Hide
            Jorge Ramos added a comment -

            It's happen to us with a 2.2.5, I'm going to apply the patch and to see what happen...

            Show
            Jorge Ramos added a comment - It's happen to us with a 2.2.5, I'm going to apply the patch and to see what happen...
            Hide
            Andrew Davis added a comment -

            Jorge, its possible you've encountered MDL-33117 which is currently being worked on. If you could test the proposed solution there and let me know whether it solves your problem that would be greatly appreciated.

            Show
            Andrew Davis added a comment - Jorge, its possible you've encountered MDL-33117 which is currently being worked on. If you could test the proposed solution there and let me know whether it solves your problem that would be greatly appreciated.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: