Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Comments
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      At present each click on (X) next to comments deletes it without any confirmation, we always confirm before any delete - imagine those unfortunate users with touch screens or touchpads

        Gliffy Diagrams

          Activity

          Hide
          skodak Petr Skoda added a comment -

          the comments report interface needs the confirmation too

          Show
          skodak Petr Skoda added a comment - the comments report interface needs the confirmation too
          Hide
          skodak Petr Skoda added a comment -

          silly question, why is the delete action not there if JS disabled? Technically it should be possible to do even without JS, right?

          Show
          skodak Petr Skoda added a comment - silly question, why is the delete action not there if JS disabled? Technically it should be possible to do even without JS, right?
          Hide
          dongsheng Dongsheng Cai added a comment -

          added a small confirm box

          Show
          dongsheng Dongsheng Cai added a comment - added a small confirm box
          Hide
          skodak Petr Skoda added a comment -

          reopening: we should not be adding new general strings like this everywhere, who is going to translate all this?
          ccing david, could you please propose some standardised solution for this?

          Show
          skodak Petr Skoda added a comment - reopening: we should not be adding new general strings like this everywhere, who is going to translate all this? ccing david, could you please propose some standardised solution for this?
          Hide
          dougiamas Martin Dougiamas added a comment -

          "Sure" can just be "OK" or "Yes" (which already exist).

          Show
          dougiamas Martin Dougiamas added a comment - "Sure" can just be "OK" or "Yes" (which already exist).
          Hide
          dongsheng Dongsheng Cai added a comment -

          removed new strings, use existing 'yes' and 'no' strings

          Show
          dongsheng Dongsheng Cai added a comment - removed new strings, use existing 'yes' and 'no' strings

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10