Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.10
    • Component/s: Commenting
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      15464

      Description

      The problem is that the get_comments() is called from an ajax script, but the result is supposed to be rendered in html page - so in the ajax script we should do:

      $renderer = $PAGE->get_renderer('core', null, RENDERER_TARGET_GENERAL) and then pass it to the get_comments() as parameter.

        Activity

        Hide
        Dongsheng Cai added a comment -

        Petr,

        get_commens only return a list of comments, the javascript did the rendering work.
        Comments api is developed before we have render engine, so I use callback to customize the look of comment entry, it is named modname_comment_template, it will return a template used by javaScript and php to render a comment entry.

        I will made some changes to give the ocntrol to theme engine.

        Show
        Dongsheng Cai added a comment - Petr, get_commens only return a list of comments, the javascript did the rendering work. Comments api is developed before we have render engine, so I use callback to customize the look of comment entry, it is named modname_comment_template, it will return a template used by javaScript and php to render a comment entry. I will made some changes to give the ocntrol to theme engine.
        Hide
        Martin Dougiamas added a comment -

        Is this done?

        Show
        Martin Dougiamas added a comment - Is this done?
        Hide
        Dongsheng Cai added a comment -

        not yet, will work on it after finish wiki 2.

        Show
        Dongsheng Cai added a comment - not yet, will work on it after finish wiki 2.
        Hide
        Dongsheng Cai added a comment -

        This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.
        For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

        Show
        Dongsheng Cai added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: