Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19118 Comments 2.0
  3. MDL-21946

get_comments() should have $renderer parameter

    Details

    • Type: Sub-task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.10
    • Component/s: Comments
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The problem is that the get_comments() is called from an ajax script, but the result is supposed to be rendered in html page - so in the ajax script we should do:

      $renderer = $PAGE->get_renderer('core', null, RENDERER_TARGET_GENERAL) and then pass it to the get_comments() as parameter.

        Gliffy Diagrams

          Attachments

            Activity

            skodak Petr Skoda created issue -
            dongsheng Dongsheng Cai made changes -
            Field Original Value New Value
            Priority Blocker [ 1 ] Minor [ 4 ]
            dougiamas Martin Dougiamas made changes -
            Fix Version/s 2.0.1 [ 10420 ]
            Fix Version/s 2.0 [ 10122 ]
            dougiamas Martin Dougiamas made changes -
            Workflow jira [ 35652 ] MDL Workflow [ 46034 ]
            dougiamas Martin Dougiamas made changes -
            Fix Version/s 2.0.2 [ 10421 ]
            Fix Version/s 2.0.1 [ 10420 ]
            dougiamas Martin Dougiamas made changes -
            Fix Version/s 2.0.3 [ 10537 ]
            Fix Version/s 2.0.2 [ 10421 ]
            dougiamas Martin Dougiamas made changes -
            Workflow MDL Workflow [ 46034 ] MDL Full Workflow [ 74350 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s 2.0.4 [ 10652 ]
            Fix Version/s 2.0.3 [ 10537 ]
            dougiamas Martin Dougiamas made changes -
            Fix Version/s 2.0.5 [ 10950 ]
            Fix Version/s 2.0.4 [ 10652 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s 2.0.6 [ 11250 ]
            Fix Version/s 2.0.5 [ 10950 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s 2.0.7 [ 11451 ]
            Fix Version/s 2.0.6 [ 11250 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s 2.0.8 [ 11554 ]
            Fix Version/s 2.0.7 [ 11451 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s 2.0.9 [ 12051 ]
            Fix Version/s 2.0.8 [ 11554 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s 2.0.10 [ 12160 ]
            Fix Version/s 2.0.9 [ 12051 ]
            dongsheng Dongsheng Cai made changes -
            Assignee Dongsheng Cai [ dongsheng ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Fix Release Date:
                  9/Jul/12