Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19118 Comments 2.0
  3. MDL-21952

DB update operations do not return bools any more, remove the result handling from comments

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Comments
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      For a very long time the DB api is not returning bools from insert_record(), delete_records(), etc. the return true is there only for BC reasons, but no new code should actually test it because we use exceptions...

      Please remove the $return handling code from comments and rely only on exceptions which are already handled properly by the new ajax error handler

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                dongsheng Dongsheng Cai
                Reporter:
                skodak Petr Skoda
                Tester:
                Nobody
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10