Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19118 Comments 2.0
  3. MDL-21955

potential page parameter collision in nonjs comments paging code

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Comments
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      it should probably use a custom $pagevar instead of usurping the 'page' GET parameter, it might be a problem especially when page already used for something else on that page or if another instance of paging existed on the same page - in general all subsystems should use some kind of unique prefix imho.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                dongsheng Dongsheng Cai
                Reporter:
                skodak Petr Skoda
                Tester:
                Nobody
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: