Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19118 Comments 2.0
  3. MDL-21957

do not use redirect messages if page not already started

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Comments
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The redirect should be always used before printing of page header, only if we have to do that afterwards the message may be actually needed because the user might have to press continue button.

      Now in the vast majority of cases the message in the fast redirect is absolutely useless because the user should actually see that something happened, or else they will get error, whitescree, etc - so the message would not be actually printed anyway.

      There is also the accessibility reason, the 3 second delay is confusing for most users...

      so in comment/admin.php the following is clearly wrong:
      redirect($CFG->httpswwwroot.'/comment/', get_string('deleted'));

      because you click on delete and you either get error when it can not be deleted, or the comment disappears and user can see that it was deleted

        Attachments

          Activity

            People

            • Assignee:
              dongsheng Dongsheng Cai
              Reporter:
              skodak Petr Skoda
              Tester:
              Nobody
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                24/Nov/10