See - http://docs.moodle.org/en/Development:Navigation_2.0_structure
Have attached a patch here to modify navigation to fit the structure proposed in http://docs.moodle.org/en/Development:Navigation_2.0_structure.
At the same time I have greatly tidied up the navigation code and renamed the blocks to navigation and settings.
I still have more testing to do before I am ready to commit but if anyone finds a minute to check the code for me I'd be most appreciative.
Fixed conflicts after Friday's commits and reattached patch
Hmmm I have found an issue with the navigation in regards to the user context.... which was always a little hacky anyway.
I'll try to work out a nice solution and ask questions here if I get stuck
Attached a file that fixes a further couple of navigation issues.
When viewing a course:
( ! ) Fatal error: Call to a member function make_active() on a non-object in /web/head/lib/navigationlib.php on line 838
( ) ../view.php:0
2 0.3645 21880660 core_renderer->header( ) ../view.php:199
3 0.3790 22505076 core_renderer->render_page_layout( ) ../outputrenderers.php:565
4 0.3794 22569776 include( '/web/head/theme/base/layout/general.php' ) ../outputrenderers.php:607
5 0.3794 22571400 moodle_page->has_navbar( ) ../general.php:4
6 0.3795 22572172 navbar->has_items( ) ../pagelib.php:588
7 0.3798 22576476 global_navigation->initialise( ) ../navigationlib.php:1585
Here goes the latest patch, will comment on it soon but in short resolved the issue you saw, cleaned up several more context issues and did a bit more tiding.
At this point I am pretty happy with it, only thing left is the simpletests
+1 (done only quick review)
Here is the latest patch: fixed conflicts from recent updates and have corrected what the navbar was showing when browsing /my/index.php
Martin once you are happy with this I will commit.
Hi guys, I have just commit my changes to this issue now!
The following are changes that are made by this commit:
Please let me know if you spot any breakages.
Well done man, looks a lot cleaner now.
Reopen if anything major arises.