Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-2207

Courses not sorted by sortorder on front page

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 1.4.2
    • Fix Version/s: None
    • Component/s: Course
    • Labels:
      None
    • Environment:
      Windows XP

      Description

      The courses are not being sorted by their course orders on the front page, rather, it seems, by their course id's.

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          From Martin Dougiamas (martin at moodle.com) Sunday, 21 November 2004, 10:54 PM:

          See MDL-2200 - fixed in very latest versions

          From Jean-Michel Vedrine (vedrine at univ-st-etienne.fr) Monday, 22 November 2004, 01:01 AM:

          Martin,

          it seems to me that you fixed it in category listing but not in frontpage listing. You need to apply the same correction to function print_category_info in courses/lib.php namely change line 1142 from :

          $courses = get_courses($category->id, NULL, 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.password,c.summary');

          to :

          $courses = get_courses($category->id, 'c.sortorder ASC', 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.password,c.summary');

          Maybe it's just Sourceforge public access to CVS who isn't up to date but I just looked 5 minutes ago and it was not corrected.

          From (cernagenr at central.adzu.edu.ph) Monday, 22 November 2004, 10:04 AM:

          I just downloaded from the CVS, still the same problem exist. Maybe there's a problem in CVS.

          From (penny at catalyst.net.nz) Tuesday, 23 November 2004, 05:35 AM:

          I just applied that fix for the front page listing. (cvs stable & head)

          thanks.

          From (cernagenr at central.adzu.edu.ph) Tuesday, 23 November 2004, 11:09 AM:

          got it... thanks

          Show
          dougiamas Martin Dougiamas added a comment - From Martin Dougiamas (martin at moodle.com) Sunday, 21 November 2004, 10:54 PM: See MDL-2200 - fixed in very latest versions From Jean-Michel Vedrine (vedrine at univ-st-etienne.fr) Monday, 22 November 2004, 01:01 AM: Martin, it seems to me that you fixed it in category listing but not in frontpage listing. You need to apply the same correction to function print_category_info in courses/lib.php namely change line 1142 from : $courses = get_courses($category->id, NULL, 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.password,c.summary'); to : $courses = get_courses($category->id, 'c.sortorder ASC', 'c.id,c.sortorder,c.visible,c.fullname,c.shortname,c.password,c.summary'); Maybe it's just Sourceforge public access to CVS who isn't up to date but I just looked 5 minutes ago and it was not corrected. From (cernagenr at central.adzu.edu.ph) Monday, 22 November 2004, 10:04 AM: I just downloaded from the CVS, still the same problem exist. Maybe there's a problem in CVS. From (penny at catalyst.net.nz) Tuesday, 23 November 2004, 05:35 AM: I just applied that fix for the front page listing. (cvs stable & head) thanks. From (cernagenr at central.adzu.edu.ph) Tuesday, 23 November 2004, 11:09 AM: got it... thanks

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: