Moodle
  1. Moodle
  2. MDL-22108

Remove scroll and overflow rules form stylesheets

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Themes
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      26647

      Description

      Horizontal scrollbars in sidebars are a bad design choice. The attached files present a solution that prevents the scrollbars from appearing and wraps lines that are too long to fit inside the sideblock column at certain resolutions.

      Let me know if there is a better way to present output then the format I've chosen to use.

      1. base-style-core.txt
        0.5 kB
        Patrick Malley
      2. global_navigation_block-styles.txt
        2 kB
        Patrick Malley
      3. settings_navigation_block-styles.txt
        2 kB
        Patrick Malley
      1. scrollgone.navigation.20100419.jpg
        65 kB

        Activity

        Hide
        Petr Škoda added a comment -

        thanks for the patches, assigning to Sam - please review

        Show
        Petr Škoda added a comment - thanks for the patches, assigning to Sam - please review
        Hide
        Sam Hemelryk added a comment -

        Reviewed and commit.

        Show
        Sam Hemelryk added a comment - Reviewed and commit.
        Hide
        Patrick Malley added a comment -

        Hey Sam,

        Thanks.

        Removing

        .block_js_expansion .block_tree

        {overflow-x:scroll;}

        from base/core.css may have been a bit premature, so I'm putting it back until I hear more on why this block behaves the way it does. I'm trying to get rid of the scrollbar, but it appears getting rid of it does strange things that are equally undesirable. Do you know who did the work on this?

        Show
        Patrick Malley added a comment - Hey Sam, Thanks. Removing .block_js_expansion .block_tree {overflow-x:scroll;} from base/core.css may have been a bit premature, so I'm putting it back until I hear more on why this block behaves the way it does. I'm trying to get rid of the scrollbar, but it appears getting rid of it does strange things that are equally undesirable. Do you know who did the work on this?
        Hide
        Sam Hemelryk added a comment -

        Hi Patrick,

        I've attached a screenshot of the navigation now with large content.
        Are you happy with the way it is wrapping currently, I agree that the horizontal scrollbars were absolutely awful but I am a little concerned with how unusable the navigation will become if there are several long winded items in the navigation.
        In the screenshot there are just two but if there are say 15?
        I would be most interested in any ideas you have in this respect, perhaps MDL-21350 may be pertinent to have a look at as well.

        Show
        Sam Hemelryk added a comment - Hi Patrick, I've attached a screenshot of the navigation now with large content. Are you happy with the way it is wrapping currently, I agree that the horizontal scrollbars were absolutely awful but I am a little concerned with how unusable the navigation will become if there are several long winded items in the navigation. In the screenshot there are just two but if there are say 15? I would be most interested in any ideas you have in this respect, perhaps MDL-21350 may be pertinent to have a look at as well.
        Hide
        Patrick Malley added a comment -

        Thanks for the screenshot. Now, I see how the scrollbars made there way into this sideblock.

        Lines should wrap. But, some sort of truncating will need to take place or we'll end up with an even worse problem.

        Show
        Patrick Malley added a comment - Thanks for the screenshot. Now, I see how the scrollbars made there way into this sideblock. Lines should wrap. But, some sort of truncating will need to take place or we'll end up with an even worse problem.
        Hide
        Sam Hemelryk added a comment -

        Hi Patrick,

        Navigation and settings blocks were written by me way back when I first started here.
        I always hated the scroll bars but hmmmm its a hard one, I would love a solution to this that did get rid of those scroll bars.
        Let me know if you would like me to revert my last commits.

        Show
        Sam Hemelryk added a comment - Hi Patrick, Navigation and settings blocks were written by me way back when I first started here. I always hated the scroll bars but hmmmm its a hard one, I would love a solution to this that did get rid of those scroll bars. Let me know if you would like me to revert my last commits.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: