Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Conditional activities
    • Labels:
      None

      Description

      I think I understand what you're trying to do with data_object.php, and it's an interesting concept, but it makes all the code look and function unlike the rest of Moodle, and it's doubtful the rest of Moodle will change to use data_object in a hurry.

      Unfortunately this new class design is making it very difficult for me to understand how your code works, which is a real impediment to getting it reviewed and included in Moodle 2.0.

      At very least it should be in lib/completion, not lib/.

      Can you write up a quick document explaining how your design works? Have you thought about scalability?

        Attachments

          Activity

            People

            Assignee:
            dougiamas Martin Dougiamas
            Reporter:
            dougiamas Martin Dougiamas
            Tester:
            Nobody
            Participants:
            Component watchers:
            Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              24/Nov/10