Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22244

mnet timestamp inside the response should be calculated at the beginning of the xmlrpc server rather than the end.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.8, 2.0
    • Fix Version/s: None
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      For mnet requests that take a long time, this will break the server offset drift detection.

        Gliffy Diagrams

          Activity

          Hide
          mjollnir Penny Leach added a comment -

          Pete - what do you think about this?

          The problem is that the XML response contains <timestamp>

          {unixtime}

          </timestamp>, and the time() call is during the formatting of the response, which is at the end, after the dispatch and processing.

          However, this value is used to detect drift between servers, so it may be actually better to calculate the time() at the beginning of the server handler.

          Show
          mjollnir Penny Leach added a comment - Pete - what do you think about this? The problem is that the XML response contains <timestamp> {unixtime} </timestamp>, and the time() call is during the formatting of the response, which is at the end, after the dispatch and processing. However, this value is used to detect drift between servers, so it may be actually better to calculate the time() at the beginning of the server handler.
          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d.

          TW9vZGxlDQo=

          Show
          salvetore Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
          Hide
          salvetore Michael de Raadt added a comment -

          I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

          This is being done as part of a bulk annual clean-up of issues.

          If you still believe this is an issue in supported versions, please create a new issue.

          Show
          salvetore Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: