Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22259

Rename "Course Prerequisites" to "Completion Dependencies"

    Details

    • Testing Instructions:
      Hide

      Setup:

      • Enable course completion across the website in Advanced Features
      • Create 2 courses with completion enabled, and enable Self-completion criteria for both in Completion tracking settings
      • Create a third course with completion enabled, add both other courses as prerequisites in Completion tracking settings
      • Add the Completion Status block to the course
      • Enrol a user in the course
      • View the course as the enrolled user

      Places to check lang strings:

      • Completion tracking settings
      • Completion Status block, also the block "details" page (click the details link)
      • Completion course report
      Show
      Setup: Enable course completion across the website in Advanced Features Create 2 courses with completion enabled, and enable Self-completion criteria for both in Completion tracking settings Create a third course with completion enabled, add both other courses as prerequisites in Completion tracking settings Add the Completion Status block to the course Enrol a user in the course View the course as the enrolled user Places to check lang strings: Completion tracking settings Completion Status block, also the block "details" page (click the details link) Completion course report
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      (Old title was: Course prerequisite does not block access to next course)

      In the cool brand new Course completion interface, there is a "Course prerequisite" setting. Apparently, course prerequisite should block access to course "B" if course "A" is set as prerequisite for B.

      Creating course A with completion criteria, and a course B with A as prerequisite, does not seems to block any access to a student role enrolled in both.

      Not sure if it is how Course prerequisite is supposed to work, so maybe it is not a bug, however it could be worth looking at.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            sry_not4sale Aaron Barnes added a comment -

            Hi Andrea,

            Course prerequisites in course completion are requisites for completing the course - rather than blocking access to the course.

            So for instance, if course "A" is a prerequisite for course "B" - you cannot completion course "B" until you have completed course "A".

            Hope this helps,
            Aaron

            Show
            sry_not4sale Aaron Barnes added a comment - Hi Andrea, Course prerequisites in course completion are requisites for completing the course - rather than blocking access to the course. So for instance, if course "A" is a prerequisite for course "B" - you cannot completion course "B" until you have completed course "A". Hope this helps, Aaron
            Hide
            andreabix Andrea Bicciolo added a comment -

            HI Aaron,
            thank you for your clarifications, I was probably get into failure by the words "Course prerequisites" used.
            Maybe it could be worth evaluating another type of sentence, such as "Course to be finished to complete this course" or something similar, so no one can have doubt about the meaning of the setting.

            Show
            andreabix Andrea Bicciolo added a comment - HI Aaron, thank you for your clarifications, I was probably get into failure by the words "Course prerequisites" used. Maybe it could be worth evaluating another type of sentence, such as "Course to be finished to complete this course" or something similar, so no one can have doubt about the meaning of the setting.
            Hide
            sry_not4sale Aaron Barnes added a comment -

            Hi Andrea,

            How about changing the name to "Course Dependencies" or something similar?

            Cheers,
            Aaron

            Show
            sry_not4sale Aaron Barnes added a comment - Hi Andrea, How about changing the name to "Course Dependencies" or something similar? Cheers, Aaron
            Hide
            andreabix Andrea Bicciolo added a comment -

            Thanks Aaorn, "Course dependencies" looks good.

            Show
            andreabix Andrea Bicciolo added a comment - Thanks Aaorn, "Course dependencies" looks good.
            Hide
            marycooch Mary Cooch added a comment -

            I was confused by this today as well (see forum post http://moodle.org/mod/forum/discuss.php?d=155083#p680346 ) and I agreee it might be useful to rename it to be clearer.

            Show
            marycooch Mary Cooch added a comment - I was confused by this today as well (see forum post http://moodle.org/mod/forum/discuss.php?d=155083#p680346 ) and I agreee it might be useful to rename it to be clearer.
            Hide
            cprudhoe Clarence Prudhoe added a comment -

            I agree, prerequisite is the wrong term to describe this feature.

            prerequisite - required as a prior condition or course of study

            I suggest using "Preparatory Course(s)" instead.

            preparatory - relating to or engaged in study or training that serves as preparation for advanced education: a preparatory course;

            Clarence

            Show
            cprudhoe Clarence Prudhoe added a comment - I agree, prerequisite is the wrong term to describe this feature. prerequisite - required as a prior condition or course of study I suggest using "Preparatory Course(s)" instead. preparatory - relating to or engaged in study or training that serves as preparation for advanced education: a preparatory course; Clarence
            Hide
            sry_not4sale Aaron Barnes added a comment -

            What about dependency?

            dependence: the state of relying on or being controlled by someone or something else

            "Course Dependencies"

            Preparatory still sounds like you need to complete the other before beginning this. Where in actual fact you need to complete the other course before you can be found complete in the current course.

            Show
            sry_not4sale Aaron Barnes added a comment - What about dependency? dependence: the state of relying on or being controlled by someone or something else "Course Dependencies" Preparatory still sounds like you need to complete the other before beginning this. Where in actual fact you need to complete the other course before you can be found complete in the current course.
            Hide
            sry_not4sale Aaron Barnes added a comment -

            Or even

            "Completion Dependencies"

            Show
            sry_not4sale Aaron Barnes added a comment - Or even "Completion Dependencies"
            Hide
            marycooch Mary Cooch added a comment -

            Yes- "completion dependencies " gets the message across!

            Show
            marycooch Mary Cooch added a comment - Yes- "completion dependencies " gets the message across!
            Hide
            mikedesimon Mike deSimon added a comment -

            I'm curious why the process would be this way at all. A clearer functionality would be to block a course before completing another course. I can't "start" English 102 until I've "completed" 101. To only prerequisite the completion seems like a strange approach. I realize that this thread has spoken about the semantics of the functionality, but the functionality itself appears to be the issue. Am I wrong?

            Show
            mikedesimon Mike deSimon added a comment - I'm curious why the process would be this way at all. A clearer functionality would be to block a course before completing another course. I can't "start" English 102 until I've "completed" 101. To only prerequisite the completion seems like a strange approach. I realize that this thread has spoken about the semantics of the functionality, but the functionality itself appears to be the issue. Am I wrong?
            Hide
            andreabix Andrea Bicciolo added a comment -

            As far as I can understand the functionality to block access to subsequent courses was not intended to be there, so the semantic should be changed accordingly.

            Show
            andreabix Andrea Bicciolo added a comment - As far as I can understand the functionality to block access to subsequent courses was not intended to be there, so the semantic should be changed accordingly.
            Hide
            merobertsjr Michael Roberts Jr added a comment -

            I agree that it would be very useful to be able to completely block enrollment or access based on other course completion. Although this is not how it was initially programmed I think this is more valuable than changing the name or what the feature is called.

            Show
            merobertsjr Michael Roberts Jr added a comment - I agree that it would be very useful to be able to completely block enrollment or access based on other course completion. Although this is not how it was initially programmed I think this is more valuable than changing the name or what the feature is called.
            Hide
            hawko Louise Hawkins added a comment -

            I agree. The ability to block course access until the pre-requisite is completed would be a useful feature. I don't really see the use of the current 'pre-requisite' function.

            Show
            hawko Louise Hawkins added a comment - I agree. The ability to block course access until the pre-requisite is completed would be a useful feature. I don't really see the use of the current 'pre-requisite' function.
            Hide
            drex Mark Drechsler added a comment -

            +1 for changing the functionality to make a prerequisite function like a prerequisite - this has caught numerous clients of mine off guard, and on seeing how it functions now the response has been quite clear that the current functionality is largely pointless for their needs.

            Pretty please can we change the functionality?

            Show
            drex Mark Drechsler added a comment - +1 for changing the functionality to make a prerequisite function like a prerequisite - this has caught numerous clients of mine off guard, and on seeing how it functions now the response has been quite clear that the current functionality is largely pointless for their needs. Pretty please can we change the functionality?
            Hide
            ghenrick gavin henrick added a comment -

            As I understand it the way it currently stands you can have an overall course("Social Media" for example) which has a set of submodules (other courses twitter, facebook etc), which must be completed before you complete Social Media. This can apply to years, semesters and overall training course, or even induction - very similar to the approach of meta-courses.

            Its a great use case, but I agree name can throw people off. +1 to rename existing functionality

            I also think the full blown prerequisite feature is neeeded (having seen it in ELIS, Totara). +1 to have that functionality

            Show
            ghenrick gavin henrick added a comment - As I understand it the way it currently stands you can have an overall course("Social Media" for example) which has a set of submodules (other courses twitter, facebook etc), which must be completed before you complete Social Media. This can apply to years, semesters and overall training course, or even induction - very similar to the approach of meta-courses. Its a great use case, but I agree name can throw people off. +1 to rename existing functionality I also think the full blown prerequisite feature is neeeded (having seen it in ELIS, Totara). +1 to have that functionality
            Hide
            drex Mark Drechsler added a comment -

            Any clues as to when this will get some priority? Starting to get more queries and puzzled looks from clients as to why this doesn't function the way people think it should.

            Show
            drex Mark Drechsler added a comment - Any clues as to when this will get some priority? Starting to get more queries and puzzled looks from clients as to why this doesn't function the way people think it should.
            Hide
            sry_not4sale Aaron Barnes added a comment -

            Once this passes peer review I will cherry-pick to the other affected branches

            Show
            sry_not4sale Aaron Barnes added a comment - Once this passes peer review I will cherry-pick to the other affected branches
            Hide
            abgreeve Adrian Greeve added a comment -

            The string changes look good.
            Reading the documentation for the page http://docs.moodle.org/23/en/course/completion the description here clarifies what this setting does. I give my +1 for changing the strings to "Completion Dependencies". An additional idea would be to add a help link with possibly the description from http://docs.moodle.org/23/en/course/completion#Course_prerequisites So that Teachers can fully understand what is happening.

            It may also be a good idea to raise a new issue for an improvement / new feature of course prerequisites.

            One other thing. Please include a set of test instructions.

            Thanks.

            Show
            abgreeve Adrian Greeve added a comment - The string changes look good. Reading the documentation for the page http://docs.moodle.org/23/en/course/completion the description here clarifies what this setting does. I give my +1 for changing the strings to "Completion Dependencies". An additional idea would be to add a help link with possibly the description from http://docs.moodle.org/23/en/course/completion#Course_prerequisites So that Teachers can fully understand what is happening. It may also be a good idea to raise a new issue for an improvement / new feature of course prerequisites. One other thing. Please include a set of test instructions. Thanks.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Grr, sorry, wrong button.

            Show
            poltawski Dan Poltawski added a comment - Grr, sorry, wrong button.
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Everyone,

            I agree with this change. But i'm afraid we can't change the terminology like this in the stable branches. It invalidates documentation/books and generally is not fair on our users to do this kind of change part way through a release.

            So i've integrated this change into master only.

            Cheers,
            dan

            Show
            poltawski Dan Poltawski added a comment - Hi Everyone, I agree with this change. But i'm afraid we can't change the terminology like this in the stable branches. It invalidates documentation/books and generally is not fair on our users to do this kind of change part way through a release. So i've integrated this change into master only. Cheers, dan
            Hide
            dmonllao David Monllaó added a comment -

            Tested on master. It passes

            Show
            dmonllao David Monllaó added a comment - Tested on master. It passes
            Hide
            poltawski Dan Poltawski added a comment -

            *Notice*: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26

            Congratulations

            {tracker.user.name}

            !

            You've made into Moodle

            {tracker.fixversion-1}

            +

            I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world.

            cheers!

            {tracker.friendlyintegrator}
            Show
            poltawski Dan Poltawski added a comment - * Notice *: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26 Congratulations {tracker.user.name} ! You've made into Moodle {tracker.fixversion-1} + I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world. cheers! {tracker.friendlyintegrator}
            Hide
            marycooch Mary Cooch added a comment -

            Removing docs_required label as this highly welcome change has now been documented http://docs.moodle.org/24/en/Course_completion_settings

            Show
            marycooch Mary Cooch added a comment - Removing docs_required label as this highly welcome change has now been documented http://docs.moodle.org/24/en/Course_completion_settings

              People

              • Votes:
                8 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12