Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-2227

bug in pclzip.php causing scorm errors

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: None
    • Component/s: Administration
    • Labels:
      None
    • Environment:
      Windows XP
    • Affected Branches:
      MOODLE_14_STABLE

      Description

      Hi Martin,

      There is a problem in D:\moodle-1.4.1\moodle\lib\pclzip\pclzip.lib.php::privExtractByRule()

      The function returns a error even if the value of the pathin the p_path variable is valid

      $p_path = d:\moodle-1.4.1\brightlinemoodledata/5/moddata/scorm/SCORMojTcrBMl

      The problematic statement was

      if (($p_path == ) // ((substr($p_path, 0, 1) != /) && (substr($p_path, 0, 3) != ../) && (substr($p_path,1,2)!=:/)))

      $p_path = ./.$p_path;

      To resolve the issue I modified it with this statement

      if (($p_path == ) // ((substr($p_path, 0, 1) != /) && (substr($p_path, 0, 3) != ../) && (substr($p_path,1,2)!=:/)) // ((substr($p_path, 0, 1) != ) && (substr($p_path, 0, 3) != ..) && (substr($p_path,1,2)!=:)))

      $p_path = ./.$p_path;

      Regards,

      Mustali K

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: