Moodle
  1. Moodle
  2. MDL-22308

Update bennu library to latest release

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.9, 2.0
    • Fix Version/s: 2.1
    • Component/s: Calendar
    • Labels:
    • Rank:
      5983

      Description

      The bennu iCal library has been updated to support unserialisation of iCal files into PHP objects.
      By updating the version in Moodle to the latest from SVN (revision 3) it will enable the implementation of iCal import functionality.

      The URL links to the SourceForge page with details of the SVN repository.

        Issue Links

          Activity

          Mark Johnson created issue -
          Mark Johnson made changes -
          Field Original Value New Value
          Link This issue will help resolve MDL-16660 [ MDL-16660 ]
          Hide
          Mark Johnson added a comment -

          This zip contains the latest version of the bennu library.
          These files are a drop-in replacement for those in /lib/bennu

          Show
          Mark Johnson added a comment - This zip contains the latest version of the bennu library. These files are a drop-in replacement for those in /lib/bennu
          Mark Johnson made changes -
          Attachment bennu.zip [ 20155 ]
          Martin Dougiamas made changes -
          Workflow jira [ 36161 ] MDL Workflow [ 46174 ]
          Hide
          Jonathan Harker added a comment -

          Hi - I've got a commit here that applies the code in that zip file in a sensible way (i.e. only keeps the relevant code changes - ignoring things like $Id$ versions, trailing ?> EOF tags and so on, and the ereg() call in lib/bennu/iCalendar_rfc2445.php is kept as preg_match().
          http://git.catalyst.net.nz/gw?p=moodle-r2.git;a=commitdiff;h=e06d238180d49d68344cc12c2fbb81978ae1da22
          I'll see about getting this pulled into both 2.0 master and MOODLE_19_STABLE

          Show
          Jonathan Harker added a comment - Hi - I've got a commit here that applies the code in that zip file in a sensible way (i.e. only keeps the relevant code changes - ignoring things like $Id$ versions, trailing ?> EOF tags and so on, and the ereg() call in lib/bennu/iCalendar_rfc2445.php is kept as preg_match(). http://git.catalyst.net.nz/gw?p=moodle-r2.git;a=commitdiff;h=e06d238180d49d68344cc12c2fbb81978ae1da22 I'll see about getting this pulled into both 2.0 master and MOODLE_19_STABLE
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Raising to Major, assigning to Martin, for his consideration and moving to DEV backlog.

          I think both MDL-22308 (this) and MDL-16660 (subscribe/import icals) could be an interesting target for 2.1 (much in line with the blogs importing thing).

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Raising to Major, assigning to Martin, for his consideration and moving to DEV backlog. I think both MDL-22308 (this) and MDL-16660 (subscribe/import icals) could be an interesting target for 2.1 (much in line with the blogs importing thing). Ciao
          Eloy Lafuente (stronk7) made changes -
          Labels triaged
          Assignee Nobody [ nobody ] Martin Dougiamas [ dougiamas ]
          Fix Version/s DEV backlog [ 10464 ]
          Priority Minor [ 4 ] Major [ 3 ]
          Difficulty Moderate
          Hide
          Jonathan Harker added a comment -

          I've contacted JP about a couple of bug fixes to bennu - in the meantime they are in my git repo here: http://gitorious.org/bennu/bennu/commits/

          Show
          Jonathan Harker added a comment - I've contacted JP about a couple of bug fixes to bennu - in the meantime they are in my git repo here: http://gitorious.org/bennu/bennu/commits/
          Hide
          Jonathan Harker added a comment -

          I've committed some fixes to Bennu upsteam on Sourceforge (cheers, JP!)

          Show
          Jonathan Harker added a comment - I've committed some fixes to Bennu upsteam on Sourceforge (cheers, JP!)
          Show
          Jonathan Harker added a comment - Pull request: http://git.catalyst.net.nz/gw?p=moodle-r2.git;a=shortlog;h=refs/heads/MDL-22308_20
          Jonathan Harker made changes -
          Link This issue will be resolved by PULL-591 [ PULL-591 ]
          Hide
          Petr Škoda added a comment -

          Thanks.

          Show
          Petr Škoda added a comment - Thanks.
          Petr Škoda made changes -
          Status Open [ 1 ] Ready for review [ 10010 ]
          Fix Version/s 2.1 [ 10370 ]
          Fix Version/s DEV backlog [ 10464 ]
          Resolution Fixed [ 1 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 46174 ] MDL Full Workflow [ 76452 ]
          Martin Dougiamas made changes -
          Status Waiting for review [ 10010 ] Closed [ 6 ]

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: