From Petr Skoda (skodak at centrum.cz) Saturday, 27 November 2004, 06:52 PM:
I sent them a report about missing trailing slash only
I vote for inclusion in 14_STABLE too.
From Martin Langhoff (martin at catalyst.net.nz) Monday, 29 November 2004, 04:36 AM:
Eloy, if you are confident enough to include in in STABLE, then go for it. I am assuming your testing will also cover other areas that use zip/unzip.
Random questions: Does PCLZip have a bugzilla thingy? Should we monitor that or at least subscribe to their announcements mailing list?
From Petr Skoda (skodak at centrum.cz) Monday, 29 November 2004, 04:57 AM:
I just looked at pclzip CVS at sf.net, IMO we could update to the latest 2.4RC1.
From Eloy Lafuente (stronk7 at moodle.org) Monday, 29 November 2004, 08:09 AM:
Tomorrow I'll test this 'demo' courses in my test linux box at the University. I'll generate two more 'demo' courses there and then I'll test them at home (Mac and Win32).
I suppose that, with zip & unzip working in backup & restore, everything should work fine. If you think that it isn't enough, please, attach here some files and/or steps to test. As now it's centralised I was assuming that having it working in backup was fine!
And yes, once tests finish, perhaps 2.4RC1 was a better option, although it isn't a public release...
From Eloy Lafuente (stronk7 at moodle.org) Monday, 29 November 2004, 07:13 PM:
please can somebody make this:
- Install pclzip.lib.php 2.3 in his LINUX test server.
- Restore any of the attachments in this bug.
- Leave zip variable blank and backup the course.
- Attach such course (called 'internallinux.zip') in this bug.
I was trying to do that in my linux server in the University, but I've some products running there and I cannot upgrade it.
With that file attached, I'll be able to test all the attachments in every plattform. TIA !!
PS: About other tests to do with the new pclzip.lib.php release, anything interesting. FileManager seems to work fine in my Mac and Win32 machines. Possible tests ideas will be welcome!
From Martin Dougiamas (martin at moodle.com) Monday, 29 November 2004, 07:54 PM:
No worries - doing it now!
From Martin Dougiamas (martin at moodle.com) Monday, 29 November 2004, 11:20 PM:
ALL of them restored nicely on my 1.4 STABLE site using the new pclzip!
I've just attached the new backup for you.
I did see some notices ... one in pclzip and some others among the other backups code ... I'll document them here in case it's important.
Notice: Undefined index: filename_len in /data/www/html/server/stable/lib/pclzip/pclzip.lib.php on line 3949
Notice: Undefined index: NUMERICAL_UNITS in /data/www/html/server/stable/mod/quiz/restorelib.php on line 1140
Notice: Trying to get property of non-object in /data/www/html/server/stable/backup/lib.php on line 459
Notice: Undefined index: SUBSCRIPTIONS in /data/www/html/server/stable/mod/forum/restorelib.php on line 131
Notice: Undefined index: DISCUSSIONS in /data/www/html/server/stable/mod/forum/restorelib.php on line 186
Notice: Undefined index: RATINGS in /data/www/html/server/stable/mod/forum/restorelib.php on line 437
Notice: Undefined index: COMMENTS in /data/www/html/server/stable/mod/glossary/restorelib.php on line 231
Notice: Undefined variable: sub_info in /data/www/html/server/stable/mod/journal/restorelib.php on line 107
Notice: Undefined index: ANALYSIS in /data/www/html/server/stable/mod/survey/restorelib.php on line 153
Notice: Undefined index: WIKI in /data/www/html/server/stable/mod/wiki/restorelib.php on line 169
Notice: Undefined variable: r in /data/www/html/server/stable/mod/wiki/restorelib.php on line 193
From Martin Dougiamas (martin at moodle.com) Monday, 29 November 2004, 11:24 PM:
I also think the 2.4 dev version should go into STABLE... Eloy, can you put it in when you're ready?
From Eloy Lafuente (stronk7 at moodle.org) Tuesday, 30 November 2004, 03:52 AM:
thanks for the missing attach. Now I'll test everything against 2.4 dev version. If everything works fine, I'll put it in MOODLE_14_STABLE and HEAD.
About notices, backup related can be 'normal' mainly because not all backups contains all sections. The pclzip one is new (I saw it yesterday too) but things seems to work. Anyway, I'll try to avoid some of them...
From Eloy Lafuente (stronk7 at moodle.org) Tuesday, 30 November 2004, 08:07 AM:
I've tested all the examples against pclzip 2.4RC01. Everything seems to work. I've tested the FileManager and SCORM unzip too. Was fine (I think).
So, if nobody has anything against it, I'll upgrade MOODLE_14 and HEAD to pclzip 2.4RC01.
About pclzip notice I've submitted a bug to the authors. About backup & restore notices, I'll take a look to them in some hours, specially strange some FALSE strings showed in progress...
From Eloy Lafuente (stronk7 at moodle.org) Wednesday, 1 December 2004, 01:58 AM:
Done (MOODLE_14_STABLE and HEAD). I'll close this bug in some days...
From Eloy Lafuente (stronk7 at moodle.org) Sunday, 19 December 2004, 04:31 AM: