Moodle
  1. Moodle
  2. MDL-22412

purge moodle 2.0 of references to the old ratings tables

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0.1
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      1122

      Description

      The Moodle 2.0 code still contains some references to the tables forum_ratings, glossary_ratings and data_ratings. They can all be removed. Its possible some instances may need to be refactored to use the new ratings system but that is unlikely. Theyre mostly in old backup/restore code that has since been replaced.

        Activity

        Hide
        Andrew Davis added a comment -

        Attaching a patch that removes the last references to the table forum_ratings. They were all in backup code that I don't think is being used anymore.

        Eloy, what is happening with files like mod/forum/backuplib.php and /mod/forum/restorelib.php? Are they used by the new backup or can they be removed entirely.

        Show
        Andrew Davis added a comment - Attaching a patch that removes the last references to the table forum_ratings. They were all in backup code that I don't think is being used anymore. Eloy, what is happening with files like mod/forum/backuplib.php and /mod/forum/restorelib.php? Are they used by the new backup or can they be removed entirely.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Oh, plz, keep them unmodified (in backuplib and restorelib) for now. They contain information that will be useful when implementing the 1.9 => 2.0 conversion of backup files and restore.

        thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Oh, plz, keep them unmodified (in backuplib and restorelib) for now. They contain information that will be useful when implementing the 1.9 => 2.0 conversion of backup files and restore. thanks!
        Hide
        Andrew Davis added a comment -

        ok, Ill just park this issue until the new backup/restore is complete.

        Show
        Andrew Davis added a comment - ok, Ill just park this issue until the new backup/restore is complete.
        Hide
        Andrew Davis added a comment -

        Just had to remove some commented out code in the end.

        Show
        Andrew Davis added a comment - Just had to remove some commented out code in the end.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: