Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 1.9.8, 2.2
-
Component/s: Libraries
-
Testing Instructions:Hide
I have no idea how to test this. Talked to Dan and he said this came up in some contrib plugin situation. So code review + regression testing with the login , logout, forget password system should be fine.
Else you can try harassing the integrator/Peer-reviewer to give you more specific testing instructions
ShowI have no idea how to test this. Talked to Dan and he said this came up in some contrib plugin situation. So code review + regression testing with the login , logout, forget password system should be fine. Else you can try harassing the integrator/Peer-reviewer to give you more specific testing instructions -
Affected Branches:MOODLE_19_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull Master Branch:
MDL-22510-master -
Pull Master Diff URL:
Description
took me ages to trace this! - the function require_login always sets wantsurl if the user requires a password change - even if $setwantsurltome is set to false.
patch attached.
Gliffy Diagrams
Issue Links
- blocks
-
MDL-29678
'Error: A required parameter (id) was missing' when using enrolment key to join course
-
- Closed
-
Activity
up for peer-review
Thanks
Hi Ankit,
The changes look good.
Thanks for fixing it.
Feel free to submit it for integration review.
Haha brilliant! this patch has been integrated now.
Not only that but it has lead me to understand an intermittent problem encountered by the navigation where immediately after login a user is redirected to the navigations AJAX script.
Cheers
Sam
Passing the test, as patch review looks good.
Don't know how to test it... So assuming all well
Thanks for reporting this issue.
We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.
If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.
Michael d;
lqjjLKA0p6