Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22510

require_login doesn't respect $setwantsurltome when Password change required.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      I have no idea how to test this. Talked to Dan and he said this came up in some contrib plugin situation. So code review + regression testing with the login , logout, forget password system should be fine.
      Else you can try harassing the integrator/Peer-reviewer to give you more specific testing instructions

      Show
      I have no idea how to test this. Talked to Dan and he said this came up in some contrib plugin situation. So code review + regression testing with the login , logout, forget password system should be fine. Else you can try harassing the integrator/Peer-reviewer to give you more specific testing instructions
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-22510-master
    • Pull Master Diff URL:

      Description

      took me ages to trace this! - the function require_login always sets wantsurl if the user requires a password change - even if $setwantsurltome is set to false.

      patch attached.

        Attachments

          Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29678 'Error: A required parameter (id) was missing' when using enrolment key to join course

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              danmarsden Dan Marsden
              Peer reviewer:
              Rossiani Wijaya Rossiani Wijaya
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Rajesh Taneja Rajesh Taneja
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12