Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22510

require_login doesn't respect $setwantsurltome when Password change required.

          Details

          • Testing Instructions:
            Hide

            I have no idea how to test this. Talked to Dan and he said this came up in some contrib plugin situation. So code review + regression testing with the login , logout, forget password system should be fine.
            Else you can try harassing the integrator/Peer-reviewer to give you more specific testing instructions

            Show
            I have no idea how to test this. Talked to Dan and he said this came up in some contrib plugin situation. So code review + regression testing with the login , logout, forget password system should be fine. Else you can try harassing the integrator/Peer-reviewer to give you more specific testing instructions
          • Affected Branches:
            MOODLE_19_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Pull Master Branch:
            MDL-22510-master
          • Pull Master Diff URL:

            Description

            took me ages to trace this! - the function require_login always sets wantsurl if the user requires a password change - even if $setwantsurltome is set to false.

            patch attached.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  blocks

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29678 'Error: A required parameter (id) was missing' when using enrolment key to join course

                  • Major - Major loss of function, incorrect output
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    salvetore Michael de Raadt added a comment -

                    Thanks for reporting this issue.

                    We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

                    If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

                    Michael d;

                    lqjjLKA0p6

                    Show
                    salvetore Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d; lqjjLKA0p6
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    up for peer-review
                    Thanks

                    Show
                    ankit_frenz Ankit Agarwal added a comment - up for peer-review Thanks
                    Hide
                    Permalink
                    rwijaya Rossiani Wijaya added a comment -

                    Hi Ankit,

                    The changes look good.
                    Thanks for fixing it.
                    Feel free to submit it for integration review.

                    Show
                    rwijaya Rossiani Wijaya added a comment - Hi Ankit, The changes look good. Thanks for fixing it. Feel free to submit it for integration review.
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Haha brilliant! this patch has been integrated now.
                    Not only that but it has lead me to understand an intermittent problem encountered by the navigation where immediately after login a user is redirected to the navigations AJAX script.

                    Cheers
                    Sam

                    Show
                    samhemelryk Sam Hemelryk added a comment - Haha brilliant! this patch has been integrated now. Not only that but it has lead me to understand an intermittent problem encountered by the navigation where immediately after login a user is redirected to the navigations AJAX script. Cheers Sam
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    Passing the test, as patch review looks good.
                    Don't know how to test it... So assuming all well

                    Show
                    rajeshtaneja Rajesh Taneja added a comment - Passing the test, as patch review looks good. Don't know how to test it... So assuming all well
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    And this has landed upstream, finally! Yay!

                    תודה רבה && شكرا جزيلا



                    Closing, ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - And this has landed upstream, finally! Yay! תודה רבה && شكرا جزيلا Closing, ciao

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        0 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          14/May/12