Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-22551

Wrong "In-Reply-To" and "References" headers in mails for first post of a thread

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.8
    • Fix Version/s: 1.9.10
    • Component/s: Forum
    • Labels:
      None
    • Environment:
      probably any Moodle installation; effect becomes visible in Thunderbird/Icedove 3
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Steps to reproduce:

      • subscribe to one or more forums
      • create some posts (new threads and replies)
      • read received mails in Thunderbird/Icedove 3
      • "View" - "Sort by" - "Threaded"

      Actual results:
      Thunderbird chooses one mail as root node (apparently the oldest forum post that is not a reply) and arranges other mails as replies below this single mail. For mailboxes with a lot of (moodle-)mails Thunderbird needs unusual long time for reordering the list. Mails for posts that are starting a new thread (thus are no replies) contain header fields like: In-Reply-To: <moodlepost0@...> and References: <moodlepost0@...>. That means all mails of thread-initiating posts are referencing the same message ID (that doesn't exist).

      Expeceted results:

      • Thunderbird's thread view of messages should represent the thread structure of the forum.
      • Mails for posts that start a new thread should not contain In-Reply-To or References headers since they are no replies or references.

      Possible solutions:

      • moodle/mod/forum/lib.php (at $userfrom->customheaders = ...) : only append In-Reply-To and References headers if the current post is a reply ($post->parent != 0)

      Although the behaviour of Thunderbird does not seem very reasonable to me, it would probably be better not to mark non-replies as replies.

        Attachments

          Activity

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Oct/10