Moodle

When displaying a file tree in browse mode, ignore empty folders

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.0
  • Component/s: Files API
  • Labels:
    None
  • Affected Branches:
    MOODLE_20_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE

Description

As discussed last Friday (http://moodle.org/mod/cvsadmin/view.php?conversationid=4890#c199940):

When displaying a folder of files in a read-only mode

  • in server files repository plugin
  • in the new folder renderer MDL-22582

then don't display empty directories at all. This check needs to work recursively, so that even a folder that contains an empty folder won't be displayed.

We decided not to implement this in the File API, but just do it in the renderers and repository plugin.

Issue Links

has been marked as being related by

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-22582 Implement core renderer to display a read-only filearea

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Martin Dougiamas added a comment - - edited

Turns out this is really expensive ... we probably need to think about calculating it when files and fileareas are created and storing it in a new table. Possibly 2.1.

In the meantime, we can reduce the need for server files with a new "private files" repository plugin. MDL-22591

Show
Martin Dougiamas added a comment - - edited Turns out this is really expensive ... we probably need to think about calculating it when files and fileareas are created and storing it in a new table. Possibly 2.1. In the meantime, we can reduce the need for server files with a new "private files" repository plugin. MDL-22591
Hide
Permalink
Martin Dougiamas added a comment -

Is it possible to do it at all just for the current level (for the server files repository plugin)? (Without worrying about empty folders in empty folders etc)

Show
Martin Dougiamas added a comment - Is it possible to do it at all just for the current level (for the server files repository plugin)? (Without worrying about empty folders in empty folders etc)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: